[Timer] Remove "refresh" call, it is not needed #6841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/26/2023 01:43:27am UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 62186b1 Started: 07/26/2023 01:38:12am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 1 • Initial Attempt |
3.85% (1)1 / 26 runfailed over last 7 days |
11.54% (3)3 / 26 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 131 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 07/26/2023 01:43:27am UTC)
⚠️ Flakes
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Example Imagery Object Can use independent time conductor to change time
Retry 1 • Initial Attempt |
60.71% (17)17 / 28 runsfailed over last 7 days |
14.29% (4)4 / 28 runsflaked over last 7 days |
|
Example Imagery in Display Layout View Large action pauses imagery when in realtime and returns to realtime
Retry 1 • Initial Attempt |
11.11% (1)1 / 9 runfailed over last 7 days |
11.11% (1)1 / 9 runflaked over last 7 days |
|
Example Imagery in Display Layout View Large action leaves keeps realtime mode paused
Retry 1 • Initial Attempt |
0% (0)0 / 8 runsfailed over last 7 days |
25% (2)2 / 8 runsflaked over last 7 days |
|
Example Imagery in Display Layout Resizing the layout changes thumbnail visibility and size
Retry 1 • Initial Attempt |
0% (0)0 / 8 runsfailed over last 7 days |
12.50% (1)1 / 8 runflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 14 runsfailed over last 7 days |
21.43% (3)3 / 14 runsflaked over last 7 days |
|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
14.29% (2)2 / 14 runsfailed over last 7 days |
28.57% (4)4 / 14 runsflaked over last 7 days |
📄 functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 1 • Initial Attempt |
30.77% (8)8 / 26 runsfailed over last 7 days |
19.23% (5)5 / 26 runsflaked over last 7 days |
shefalijoshi
added a commit
that referenced
this pull request
Jul 28, 2023
* clock, timeConductor and appActions fixes * Ensure realtime uses upstream context when available Eliminate ambiguity when looking for time conductor locator * Fix log plot e2e tests * Fix displayLayout e2e tests * Specify global time conductor to fix issues with duplicate selectors with independent time contexts * a11y: ARIA for conductor and independent time conductor * a11y: fix label collisions, specify 'Menu' in label * Add watch mode * fix(e2e): update appActions and tests to use a11y locators for ITC * Don't remove the itc popup from the DOM. Just show/hide it once it's added the first time. * test(e2e): disable one imagery test due to known bug * Add fixme to tagging tests, issue described in 6822 * Fix locator for time conductor popups * Improve how time bounds are set in independent time conductor. Fix tests for flexible layout and timestrip * Fix some tests for itc for display layouts * Fix Inspector tabs remounting on change * fix autoscale test and snapshot * Fix telemetry table test * Fix timestrip test * e2e: move test info annotations to within test * 6826: Fixes padStart error due to using it on a number rather than a string * fix(e2e): update snapshots * fix(e2e): fix restricted notebook locator * fix(restrictedNotebook): fix issue causing sections not to update on lock * fix(restrictedNotebook): fix issue causing snapshots to not be able to be deleted from a locked page - Using `this.$delete(arr, index)` does not update the `length` property on the underlying target object, so it can lead to bizarre issues where your array is of length 4 but it has 3 objects in it. * fix: replace all instances of `$delete` with `Array.splice()` or `delete` * fix(e2e): fix grand search test * fix(#3117): can remove item from displayLayout via tree context menu while viewing another item * fix: remove typo * Wait for background image to load * fix(#6832): timelist events can tick down * fix: ensure that menuitems have the raw objects so emits work * fix: assign new arrays instead of editing state in-place * refactor(timelist): use `getClock()` instead of `clock()` * Revert "refactor(timelist): use `getClock()` instead of `clock()`" This reverts commit d888553. * refactor(timelist): use new timeAPI * Stop ticking when the independent time context is disabled (#6833) * Turn off the clock ticket for independent time conductor when it is disabled * Fix linting issues --------- Co-authored-by: Khalid Adil <[email protected]> * test: update couchdb notebook test * fix: codeQL warnings * fix(tree-item): infinite spinner issue - Using `indexOf()` with an object was failing due to some items in the tree being Proxy-wrapped and others not. So instead, use `findIndex()` with a predicate that compares the navigationPaths of both objects * [Timer] Remove "refresh" call, it is not needed (#6841) * removing an unneccessary refresh that waas causing many get requests * lets just pretend this never happened * fix(mct-tree): maintain reactivity of all tree items * Hide change role button in the indicator in cases where there is only… (#6840) Hide change role button in the indicator in cases where there is only a single role available for the current user --------- Co-authored-by: Shefali <[email protected]> Co-authored-by: Khalid Adil <[email protected]> Co-authored-by: John Hill <[email protected]> Co-authored-by: David Tsay <[email protected]> Co-authored-by: Jamie V <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6815
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist