Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for e2e tests following the Vue 3 compat upgrade #6837

Merged
merged 84 commits into from
Jul 28, 2023
Merged

Fixes for e2e tests following the Vue 3 compat upgrade #6837

merged 84 commits into from
Jul 28, 2023

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Jul 24, 2023 •
edited by unlikelyzero
Loading

Closes #6814 #6816

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

shefalijoshi and others added 30 commits July 19, 2023 16:25
@shefalijoshi @ozyx
clock, timeConductor and appActions fixes
72c432f
@shefalijoshi @ozyx
Ensure realtime uses upstream context when available
f9c5e12 
Eliminate ambiguity when looking for time conductor locator
@shefalijoshi @ozyx
Remove log statement
34229d3
@shefalijoshi @ozyx
Fix log plot e2e tests
6769fb4
@shefalijoshi @ozyx
Fix displayLayout e2e tests
9b4410d
@khalidadil
Specify global time conductor to fix issues with duplicate selectors …
c400c7c 
…with independent time contexts
@ozyx
a11y: ARIA for conductor and independent time conductor
2d16e91
@ozyx
a11y: more accessibility for TC
3dab216
@ozyx
a11y: fix label collisions, specify 'Menu' in label
c6ff7f2
@unlikelyzero
Add watch mode
6d68512
@ozyx
fix(e2e): update appActions and tests to use a11y locators for ITC
e94cf27
@davetsay
add fixmes to e2e tests failing due to regressions
f48afeb
@shefalijoshi
Don't remove the itc popup from the DOM. Just show/hide it once it's …
7db9805 
…added the first time.
@ozyx
test(e2e): disable one imagery test due to known bug
99cb909
@ozyx
test(e2e): fix ITC imagery test
dc0f461
@khalidadil
Add fixme to tagging tests, issue described in 6822
43fa104
@shefalijoshi
Fix locator for time conductor popups
625bdc0
@shefalijoshi
Improve how time bounds are set in independent time conductor.
8d5219c 
Fix tests for flexible layout and timestrip
@shefalijoshi
Fix some tests for itc for display layouts
771158d
@shefalijoshi
Fix Inspector tabs remounting on change
cb93d17
@shefalijoshi
fix autoscale test and snapshot
05a1d53
@shefalijoshi
Fix telemetry table test
c77bbc1
@shefalijoshi
Fix timestrip test
a1d9842
@ozyx
e2e: move test info annotations to within test
2719a28
@shefalijoshi
6826: Fixes padStart error due to using it on a number rather than a …
bdf8601 
…string
@ozyx
fix(e2e): update snapshots
9f77c03
@ozyx
fix(e2e): fix restricted notebook locator
9a946bc
@ozyx
fix(restrictedNotebook): fix issue causing sections not to update on …
e0fc2ae 
…lock
@shefalijoshi
Merge branch 'e2e-test-fixes' of https://github.com/nasa/openmct into…
c1d1b03 
… e2e-test-fixes
@ozyx
fix(restrictedNotebook): fix issue causing snapshots to not be able t…
76c37ff 
…o be deleted from a locked page

- Using `this.$delete(arr, index)` does not update the `length` property on the underlying target object, so it can lead to bizarre issues where your array is of length 4 but it has 3 objects in it.
@shefalijoshi
Fix notification tests
c3fa764
@shefalijoshi
Remove event listeners on unmount for notifications
c24d61c
@shefalijoshi
Adds null checks for memory search, ensure array objects are spliced …
26c47ec 
…for timeline bound changes, await limit results for plot series
@shefalijoshi
Do not allow openmct to be reactive with Vue
ee9ee5b
@shefalijoshi
Ensure calls to the view provider methods have correct parameters (ob…
9623d9a 
…jectPath)
@shefalijoshi
Fix bar graph tests
44ca7a6
@shefalijoshi
Remove xdescribe and only comment out one test for bar graph
3eef220
@shefalijoshi
Fix scatter plots tests, comment out one test
1889955
@shefalijoshi
exclude timeline tests
5221288
@shefalijoshi
Fix time conductor tests
fbefd77
@shefalijoshi
excluding layout and inspector styles tests
fb055d8
@shefalijoshi
Add missing parameters for view api
c24558e
@shefalijoshi
Disable plot tests
fa0ead4
@shefalijoshi
Disable tests for URLTimeSettingsSynchronizer
8eefd52
@shefalijoshi
Fix linting issues
40520e2
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 27, 2023
@ozyx ozyx added this to the Target:3.0.0 milestone Jul 27, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 27, 2023
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 28, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 28, 2023
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 28, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 28, 2023
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 28, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 28, 2023
@shefalijoshi shefalijoshi merged commit 16e1ac2 into master Jul 28, 2023
@shefalijoshi shefalijoshi deleted the e2e-test-fixes branch July 28, 2023 02:06
@unlikelyzero unlikelyzero linked an issue Aug 4, 2023 that may be closed by this pull request
[e2e] Add npm script for watch mode playwright execution #6816
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shefalijoshi shefalijoshi shefalijoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Target:3.0.0
Development

Successfully merging this pull request may close these issues.

[e2e] Add npm script for watch mode playwright execution Fix failing e2e tests
7 participants
@ozyx @shefalijoshi @khalidadil @unlikelyzero @davetsay @jvigliotta @charlesh88