Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timelist events don't tick down #6832

Closed
3 of 7 tasks
ozyx opened this issue Jul 21, 2023 · 4 comments
Closed
3 of 7 tasks

Timelist events don't tick down #6832

ozyx opened this issue Jul 21, 2023 · 4 comments
Labels
bug:regression It used to work. Now it doesn't :( severity:blocker type:bug verified Tested or intentionally closed
Milestone
Target:3.2.0

Comments

@ozyx
Copy link
Contributor

ozyx commented Jul 21, 2023 •
edited
Loading

Filed as VIPEROMCT-360

Summary

When using a Timelist with a Plan in it, in realtime mode the time does not count down.

Expected vs Current Behavior

The to/from times should count down as expected

Steps to Reproduce

  1. Create a Timelist
  2. Drag a Plan into it
  3. Save and exit
  4. Observe that the to/from counter doesn't count down

Environment

  • Open MCT Version: 3.0.0-SNAPSHOT 3.1.0-next
  • Deployment Type: local/testathon
  • OS: MacOS
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@ozyx ozyx added type:bug bug:regression It used to work. Now it doesn't :( labels Jul 21, 2023
@ozyx ozyx added this to the Target:3.0.0 milestone Jul 21, 2023
@ozyx ozyx self-assigned this Jul 21, 2023
ozyx added a commit that referenced this issue Jul 24, 2023
@ozyx
fix(#6832): timelist events can tick down
e92b8f9
@ozyx
Copy link
Contributor Author

ozyx commented Jul 25, 2023

Testing Instructions

  • Create a Timelist object
  • Drag a Plan into it
  • Switch to RealTime mode
  • Verify that the 'Time To/From' field values continually update as time ticks

@ozyx ozyx closed this as completed Jul 25, 2023
@rukmini-bose
Copy link
Contributor

Verified Testathon 7/25/2023

@charlesh88
Copy link
Contributor

Testathon 2023-07-25 verified fixed.

@ozyx ozyx removed the unverified label Jul 25, 2023
shefalijoshi added a commit that referenced this issue Jul 28, 2023
@ozyx @shefalijoshi
@khalidadil @unlikelyzero @davetsay @jvigliotta
Fixes for e2e tests following the Vue 3 compat upgrade (#6837)
16e1ac2 
* clock, timeConductor and appActions fixes

* Ensure realtime uses upstream context when available
Eliminate ambiguity when looking for time conductor locator

* Fix log plot e2e tests

* Fix displayLayout e2e tests

* Specify global time conductor to fix issues with duplicate selectors with independent time contexts

* a11y: ARIA for conductor and independent time conductor

* a11y: fix label collisions, specify 'Menu' in label

* Add watch mode

* fix(e2e): update appActions and tests to use a11y locators for ITC

* Don't remove the itc popup from the DOM. Just show/hide it once it's added the first time.

* test(e2e): disable one imagery test due to known bug

* Add fixme to tagging tests, issue described in 6822

* Fix locator for time conductor popups

* Improve how time bounds are set in independent time conductor.
Fix tests for flexible layout and timestrip

* Fix some tests for itc for display layouts

* Fix Inspector tabs remounting on change

* fix autoscale test and snapshot

* Fix telemetry table test

* Fix timestrip test

* e2e: move test info annotations to within test

* 6826: Fixes padStart error due to using it on a number rather than a string

* fix(e2e): update snapshots

* fix(e2e): fix restricted notebook locator

* fix(restrictedNotebook): fix issue causing sections not to update on lock

* fix(restrictedNotebook): fix issue causing snapshots to not be able to be deleted from a locked page

- Using `this.$delete(arr, index)` does not update the `length` property on the underlying target object, so it can lead to bizarre issues where your array is of length 4 but it has 3 objects in it.

* fix: replace all instances of `$delete` with `Array.splice()` or `delete`

* fix(e2e): fix grand search test

* fix(#3117): can remove item from displayLayout via tree context menu while viewing another item

* fix: remove typo 

* Wait for background image to load

* fix(#6832): timelist events can tick down

* fix: ensure that menuitems have the raw objects so emits work

* fix: assign new arrays instead of editing state in-place

* refactor(timelist): use `getClock()` instead of `clock()`

* Revert "refactor(timelist): use `getClock()` instead of `clock()`"

This reverts commit d888553.

* refactor(timelist): use new timeAPI

* Stop ticking when the independent time context is disabled (#6833)

* Turn off the clock ticket for independent time conductor when it is disabled

* Fix linting issues

---------

Co-authored-by: Khalid Adil <[email protected]>

* test: update couchdb notebook test

* fix: codeQL warnings

* fix(tree-item): infinite spinner issue

- Using `indexOf()` with an object was failing due to some items in the tree being Proxy-wrapped and others not. So instead, use `findIndex()` with a predicate that compares the navigationPaths of both objects

* [Timer] Remove "refresh" call, it is not needed (#6841)

* removing an unneccessary refresh that waas causing many get requests
* lets just pretend this never happened

* fix(mct-tree): maintain reactivity of all tree items

* Hide change role button in the indicator in cases where there is only… (#6840)

Hide change role button in the indicator in cases where there is only a single role available for the current user

---------

Co-authored-by: Shefali <[email protected]>
Co-authored-by: Khalid Adil <[email protected]>
Co-authored-by: John Hill <[email protected]>
Co-authored-by: David Tsay <[email protected]>
Co-authored-by: Jamie V <[email protected]>
@ozyx
Copy link
Contributor Author

ozyx commented Oct 3, 2023 •
edited
Loading

Guess who's back... back again...

Reopening!

jk

@ozyx ozyx reopened this Oct 3, 2023
@ozyx ozyx modified the milestones: Target:3.0.0, Target:3.2.0 Oct 3, 2023
@ozyx ozyx removed this from the Target:3.2.0 milestone Oct 12, 2023
@ozyx ozyx closed this as completed Oct 12, 2023
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:3.2.0 Feb 8, 2024
@unlikelyzero unlikelyzero added the verified Tested or intentionally closed label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:regression It used to work. Now it doesn't :( severity:blocker type:bug verified Tested or intentionally closed
Projects
None yet
Milestone
Target:3.2.0
Development

No branches or pull requests
5 participants
@charlesh88 @akhenry @ozyx @unlikelyzero @rukmini-bose