Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in timer state are not observed by other users #6880

Closed
2 of 7 tasks
akhenry opened this issue Aug 2, 2023 · 2 comments · Fixed by #6885
Closed
2 of 7 tasks

Changes in timer state are not observed by other users #6880

akhenry opened this issue Aug 2, 2023 · 2 comments · Fixed by #6885

Comments

@akhenry
Copy link
Contributor

akhenry commented Aug 2, 2023

Summary

A recent change removed refresh calls from Timers which are necessary to ensure timer state is kept consistent between multiple users. This polling strategy was always sub-optimal, but worked for simple cases where remote change detection was not supported.

Expected vs Current Behavior

When one user changes the state of a timer (eg. pauses, plays, resets) all users observing that timer should also see the change.

Steps to Reproduce

  1. Create a timer
  2. Open that timer in two windows
  3. Press play on the timer in one window
  4. Expected behavior is that the timer starts playing in the other window as well.

Environment

  • Open MCT Version: release/3.0.0
  • Deployment Type: dev

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@jvigliotta
Copy link
Contributor

jvigliotta commented Aug 2, 2023

Testing

  • follow reproduction steps in issue description
  • as well as making sure the network requests for the object are not coming in faster than once ever 2 seconds

@akhenry
Copy link
Contributor Author

akhenry commented Aug 3, 2023

Verified

@akhenry akhenry removed the unverified label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants