Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#6885): Synchronize timers between multiple users #6886

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Aug 2, 2023

#6880

  • created a throttle util and using it in timer plugin to throttle refreshing the timer domain object

  • Simplify timer logic

  • Clarify code a little

  • refactor: lint:fix

  • Fix linting issue

* created a throttle util and using it in timer plugin to throttle refreshing the timer domain object

* Simplify timer logic

* Clarify code a little

* refactor: lint:fix

* Fix linting issue

---------

Co-authored-by: Jamie V <[email protected]>
Co-authored-by: Jesse Mazzella <[email protected]>
Co-authored-by: Jesse Mazzella <[email protected]>
@ozyx ozyx requested a review from akhenry August 2, 2023 23:36
@deploysentinel
Copy link

deploysentinel bot commented Aug 2, 2023

Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/02/2023 11:44:31pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: f0f19d2

Started: 08/02/2023 11:39:33pm UTC

⚠️ Flakes

📄   functional/forms.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Persistence operations @couchdb Can create an object after a conflict error @couchdb @2p
Retry 1Initial Attempt
0% (0) 0 / 62 runs
failed over last 7 days
8.06% (5) 5 / 62 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 131 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/02/2023 11:44:31pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: f0f19d2

Started: 08/02/2023 11:38:46pm UTC

⚠️ Flakes

📄   functional/plugins/displayLayout/displayLayout.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Display Layout independent time works with display layouts and its children
Retry 1Initial Attempt
1.60% (2) 2 / 125 runs
failed over last 7 days
3.20% (4) 4 / 125 runs
flaked over last 7 days

📄   functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1Initial Attempt
0.93% (1) 1 / 108 run
failed over last 7 days
15.74% (17) 17 / 108 runs
flaked over last 7 days

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use independent time conductor to change time
Retry 2Retry 1Initial Attempt
19.66% (23) 23 / 117 runs
failed over last 7 days
19.66% (23) 23 / 117 runs
flaked over last 7 days

📄   functional/plugins/plot/autoscale.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Autoscale User can set autoscale with a valid range @snapshot
Retry 1Initial Attempt
18.10% (21) 21 / 116 runs
failed over last 7 days
21.55% (25) 25 / 116 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shefalijoshi shefalijoshi merged commit 492e805 into release/3.0.0 Aug 2, 2023
@shefalijoshi shefalijoshi deleted the cherry-pick-timers branch August 2, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants