Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend 1047 #1103

Closed
wants to merge 68 commits into from
Closed

Frontend 1047 #1103

wants to merge 68 commits into from

Conversation

charlesh88
Copy link
Contributor

@charlesh88 charlesh88 commented Jul 29, 2016

Notes

I'd love to get this merged soon so we can apply to new ongoing front-end related projects like the new Time Conductor. Although I've been very diligent about merging master in on a periodic basis, as has been mentioned, this is probably best squash merged. Related work has also been done in WARP and VISTA repos; PR's should be filed there once this is merged into open master.

getGlyph functions were recast as getCssClass and their comments were all updated. We may need a followup issue to update documentation around glyphs that isn't generated from code.

Change Summary

  • Extensive work in markup, sass, JS and tests to convert glyph approach to CSS classes. Icons for objects and actions are now defined with a "cssclass" property, using the naming pattern .icon-*. A full list of available icon classes can be referenced in /platform/commonUI/general/res/sass/_glyphs.scss and in the UI Symbols Font Map spreadsheet.
  • Updates and additions to symbols font glyphs to improve legibility, understandability and new icons for objects like overlay and stacked plot objects.
  • New look and better markup for the pane collapse/expand controls.
  • Mobile also completely updated and should be in parity.
  • Class name cleanup and normalization for button and button-menu-related classes.
  • New .s-icon-button and .s-toggle-icon classes.
  • Timeline resource icon buttons now use .s-toggle-icon class.
  • Improved sass function and classes for splitters; support for new small splitter requested for Timelines.
  • .s-status-* classes updated and fixed.
  • Fixed "snow" theme color issues with button hovers, other.
  • Multiple other minor UI / CSS improvements and fixes.

Author Checklist

  1. Changes address original issue? Y
  2. Unit tests included and/or updated with changes? Y
  3. Command line build passes? Y
  4. Changes have been smoke-tested? Y

charlesh88 and others added 30 commits June 21, 2016 18:16
Fixes #1047
- Renamed main project file;
- Added new 12px symbols project file;
Fixes #1047
- Modified sass to point to renamed font files;
- Added new 12px symbols font files to sass;
fixes #1047
Moved all glyphs into PUA area of font, and
re-organized by category.
fixes #1047
New font files; no re-mapping yet in the app.
fixes #1047
In-progess, e900 > e904
fixes #1047
Very much In-progess, s-btn and
s-btn-menu refactoring
fixes #1047
Very much In-progess, "icon-" selector,
browse bar buttons
fixes #1047
Very much In-progess, classes for all symbols
added to glyphs.scss; .menu cleaned up;
fixes #1047
Very much In-progess: convert some controls;
fixes #1047
In-progress, converting types, mods to
Create Menu template
fixes #1047
In-progess, menus and Create menu fixes
fixes #1047
In-progess: tree-labels, unknown objects, object
header
fixes #1047
In-progess: glyphs.scss now uses $vars to
allow other scss to use a var instead of string
literals;
fixes #1047
Context menus and associated actions,
custom checkboxes, tree item being edited
fixes #1047
In progress: grid items
fixes #1047
In progress, really: view icons, timer/clock
Fixes #1047
In-progress; indicators, notifications, actions,
tests
Fixes #1047
In-progress; plot options, imagery buttons,
cleanups in buttons.scss, edit-action buttons,
.s-btn .no-label class added.
Fixes #1047
In-progress; .labeled added  to .s-btn,
removed .s-icon-btn
Fixes #1047
In-progress; overlay close, search inputs,
messages and message banners,
ui-symbol removal in-progress.
fixes #1047
In progress: moved limits classes out
of _contants and into _glyphs;
timers, entanglement context menu items,
form validation, date picker.
fixes #1047
In progress: search menu
fixes #1047
In progress: updated font files glyphs, mostly
for pane collapse icons
fixes #1047
In progress: significant mods to pane collapse/expand
buttons and symbols, minor tweaks to splitter look,
limits glyph definitions
Fixes #1047
Resolved conflict in icomoon.json file
Fixes #1047
Timeline glyph refactoring; Resource Graph icons
in swimlanes now display grayed-out version when not
added to the Resource Graph; minor color tweaks
Fixes #1047
New icons for overlay and stacked plots;
revised art and new description for
Fixed Position object;
Fixes #1047
New font files that were missed in
last commit; updated icomoon proj
file; fixed missing char codes in
glyphs.scss;
Fixes #1047
Restored no-collapse and float-right
properties;
Fixes #1047
mini-tabs, splitters and bg-splash updated;
moved position of Inspector collapse mini-tab
to allow position transition;
splitter-sm class added for Timelines;
Fixes #1047
- Splitter and mini-tab-icon elements
Fixes #1047
- Finessing mini-tab and making able to
control per theme; s-clickable and s-toggle-icon
classes cleaned up
Fixes #1047
- Clock, timer, plots updated
Fixes #1047
.s-menu-btn > .s-menu-button;
.create-btn > .create-button;
removed unused l-btn, t-btn,
t-btns-zoom from markup
Fixes #1047
Fixes and enhancements for mobile,
particularly in tree;  Removed
`display: inline-block` from containerSubtle
mixin;
Fixes #1047
<mct-form> must now include class
'validates'  to display validation glyph icons;
removed 'no-validate' from markup; cleaned
up validation scss;
Fixes #1047
Fixed .s-status-editing and s-status-pending;
@charlesh88 charlesh88 added this to the Niven milestone Jul 29, 2016
@VWoeltjen
Copy link
Contributor

Changes look good (love how much easier icon-database is to understand than glyph: "D").

It looks like these changes are not backwards-compatible; will WARP/VISTA display incorrectly if this is merged to master until those corresponding PRs are merged? (Holding off on merge for now so that we can coordinate the timing on those if so.)

Reviewer Checklist

  1. Changes appear to address issue? Y
  2. Appropriate unit tests included? Y
  3. Code style and in-line documentation are appropriate? Y
  4. Commit messages meet standards? Y

@charlesh88
Copy link
Contributor Author

charlesh88 commented Aug 1, 2016

@VWoeltjen You're correct: all the symbols in WARP and VISTA will break until those PR's are merged; we should do this all at once. Let's talk about this timing in the 8/2/16 tagup.

@larkin
Copy link
Contributor

larkin commented Aug 1, 2016

@charlesh88 are the warp/vista branches ready to go? I think we can just merge and push pronto and all should be fine.

VWoeltjen added a commit that referenced this pull request Aug 1, 2016
Squashes #1103, fixes #1047.

Squashed commit of the following:

commit 0e060f1
Author: Charles Hacskaylo <[email protected]>
Date:   Fri Jul 29 14:55:34 2016 -0700

    [Frontend] Added button to .s-button

    Fixes #1047

commit 9f74395
Author: Charles Hacskaylo <[email protected]>
Date:   Fri Jul 29 14:43:36 2016 -0700

    [Frontend] Fixing problems from circleci

    Fixes #1047

commit 7278c95
Author: Charles Hacskaylo <[email protected]>
Date:   Fri Jul 29 14:37:21 2016 -0700

    [Frontend] CSS fixes for s-status classes

    Fixes #1047
    Fixed .s-status-editing and s-status-pending;

commit 4606d61
Merge: d5bff55 59436f7
Author: Charles Hacskaylo <[email protected]>
Date:   Fri Jul 29 13:58:51 2016 -0700

    Merge remote-tracking branch 'origin/master' into frontend-1047

commit d5bff55
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jul 28 19:09:33 2016 -0700

    [Frontend] Updated glyphs used by plot view switcher

    Fixes #1047

commit b72d82b
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jul 28 19:09:00 2016 -0700

    [Frontend] Tree styles in left pane and selector-list

    Fixes #1047

commit af36b99
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jul 28 18:32:34 2016 -0700

    [Frontend] Form validation styling

    Fixes #1047
    <mct-form> must now include class
    'validates'  to display validation glyph icons;
    removed 'no-validate' from markup; cleaned
    up validation scss;

commit 69dc893
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jul 28 17:11:52 2016 -0700

    [Frontend] Glyphs to classes, mobile

    Fixes #1047
    Fixes and enhancements for mobile,
    particularly in tree;  Removed
    `display: inline-block` from containerSubtle
    mixin;

commit 7bca18b
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jul 28 11:36:19 2016 -0700

    [Frontend] Rename .s-menu-btn, remove unused

    Fixes #1047
    .s-menu-btn > .s-menu-button;
    .create-btn > .create-button;
    removed unused l-btn, t-btn,
    t-btns-zoom from markup

commit 5d22919
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jul 28 11:25:36 2016 -0700

    [Frontend] Rename .s-clickable-icon to .s-icon-button

    Fixes #1047

commit 36479e2
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jul 28 11:20:30 2016 -0700

    [Frontend] Rename .s-btn to .s-button

    Fixes #1047

commit 89e4f06
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jul 28 11:12:07 2016 -0700

    [Frontend] Apply clickable-icon class

    Fixes #1047

commit e65ca1c
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jul 28 10:52:35 2016 -0700

    [Frontend] Updated icons

    Fixes #1047
    - Clock, timer, plots updated

commit 3e7eb98
Author: Charles Hacskaylo <[email protected]>
Date:   Wed Jul 27 18:05:06 2016 -0700

    [Frontend] Standardizing styles

    Fixes #1047
    - Finessing mini-tab and making able to
    control per theme; s-clickable and s-toggle-icon
    classes cleaned up

commit 18e0807
Author: Charles Hacskaylo <[email protected]>
Date:   Wed Jul 27 16:33:25 2016 -0700

    [Frontend] Tweaks to sass code

    Fixes #1047
    - Splitter and mini-tab-icon elements

commit 44fda8d
Author: Charles Hacskaylo <[email protected]>
Date:   Wed Jul 27 09:24:53 2016 -0700

    [Frontend] Multiple UI fixes and tweaks

    Fixes #1047
    mini-tabs, splitters and bg-splash updated;
    moved position of Inspector collapse mini-tab
    to allow position transition;
    splitter-sm class added for Timelines;

commit 2aee8bc
Author: Charles Hacskaylo <[email protected]>
Date:   Tue Jul 26 15:53:32 2016 -0700

    [Frontend] Updated splash image

    Fixes #1047

commit 624f097
Merge: ce7591f 4d2f159
Author: Charles Hacskaylo <[email protected]>
Date:   Tue Jul 26 15:02:55 2016 -0700

    Merge remote-tracking branch 'origin/master' into frontend-1047

commit ce7591f
Author: Charles Hacskaylo <[email protected]>
Date:   Tue Jul 26 11:22:23 2016 -0700

    [Frontend] Fixed clock indicator

    Fixes #1047
    Restored no-collapse and float-right
    properties;

commit 5324c8e
Author: Charles Hacskaylo <[email protected]>
Date:   Mon Jul 25 18:14:38 2016 -0700

    [Frontend] New font and project file

    Fixes #1047
    New font files that were missed in
    last commit; updated icomoon proj
    file; fixed missing char codes in
    glyphs.scss;

commit a3b2628
Author: Charles Hacskaylo <[email protected]>
Date:   Mon Jul 25 17:54:00 2016 -0700

    [Frontend] Revised and new icon art

    Fixes #1047
    New icons for overlay and stacked plots;
    revised art and new description for
    Fixed Position object;

commit 8a41c6d
Author: Charles Hacskaylo <[email protected]>
Date:   Mon Jul 25 17:52:41 2016 -0700

    [Frontend] Removing glyph definitions

    Fixes #1047
    Updated comment

commit eb293b2
Author: Charles Hacskaylo <[email protected]>
Date:   Mon Jul 25 11:56:18 2016 -0700

    [Frontend] Removing glyph definitions

    Fixes #1047
    Removed commented code

commit d8b1fb7
Author: Charles Hacskaylo <[email protected]>
Date:   Mon Jul 25 11:17:45 2016 -0700

    [Frontend] Removing glyph definitions; updating tests

    Fixes #1047
    Search and removal of "glyph" definitions in bundle
    and other JS files; updating tests accordingly;

commit 650fbcc
Author: Charles Hacskaylo <[email protected]>
Date:   Mon Jul 25 10:20:33 2016 -0700

    [Frontend] Removing glyph definitions; updating tests

    Fixes #1047
    Search and removal of "glyph" definitions in bundle
    and other JS files; updating tests accordingly;

commit 574b8bd
Author: Charles Hacskaylo <[email protected]>
Date:   Fri Jul 22 19:11:56 2016 -0700

    [Frontend] Updated tests for glyph refactoring

    Fixes #1047
    Fixing test cases

commit dd84177
Author: Charles Hacskaylo <[email protected]>
Date:   Fri Jul 22 18:47:45 2016 -0700

    [Frontend] Updated tests and examples for glyph refactoring

    Fixes #1047
    WIP: Fixing test cases: fixed test in Timers that was expecting
    glyph return;

commit 2231f8e
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jul 21 17:45:20 2016 -0700

    [Frontend] Updated tests for glyph refactoring

    Fixes #1047
    Fixing test cases: fixed test in Timers that was expecting
    glyph return;

commit ae59ecf
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jul 21 17:38:45 2016 -0700

    [Frontend] Fixed style

    Fixes #1047
    WIP: fixed line-height issue for t-item-icon class

commit d43bff1
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jul 21 17:07:49 2016 -0700

    [Frontend] Fixed colors

    Fixes #1047
    WIP: fixed colors  and style defs related to clickable
    icons

commit c2db6f8
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jul 21 16:32:17 2016 -0700

    [Frontend] Fixed colors

    Fixes #1047
    WIP: fixed colors related to changes to
    btnSubtle mixin; new constants for clickable
    icons

commit a4753c4
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jul 21 15:23:58 2016 -0700

    [Frontend] Added new icon-brackets to symbols font

    Fixes #1047
    WIP

commit 2704640
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jul 21 15:11:28 2016 -0700

    [Frontend] Normalize color constants

    Fixes #1047
    Normalize color constant values for themes; consolidated
    and cleaned up btn-related mixins; fixed hover color issues

commit 421286c
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jul 21 14:10:13 2016 -0700

    [Frontend] Convert new Fixed Position Display from glyphs

    Fixes #1047
    WIP

commit a4111f3
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jul 21 14:07:38 2016 -0700

    [Frontend] Refactoring Timeline glyphs, s-btn fixes

    Fixes #1047
    WIP: Timeline-related glyph refactoring; s-btn
    styles and hover color fixes

commit 883f999
Merge: 9d9cabb 14f1a1f
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jul 21 08:53:23 2016 -0700

    Merge remote-tracking branch 'origin/master' into frontend-1047

commit 9d9cabb
Author: Charles Hacskaylo <[email protected]>
Date:   Tue Jul 19 16:20:20 2016 -0700

    [Frontend] Glyph refactoring

    Fixes #1047
    WIP: search, toolbar buttons; mods
    to flex archetypes

commit 28b663c
Author: Charles Hacskaylo <[email protected]>
Date:   Mon Jul 18 14:58:40 2016 -0700

    [Frontend] Glyph-related style changes to toolbars and buttons

    Fixes #1047
    Glyph refactoring  WIP for toolbar buttons;
    Timeline glyph refactoring continued

commit a9326f5
Author: Charles Hacskaylo <[email protected]>
Date:   Mon Jul 18 13:36:45 2016 -0700

    [Frontend] Glyph-related style changes to Timelines

    Fixes #1047
    Timeline glyph refactoring; Resource Graph icons
    in swimlanes now display grayed-out version when not
    added to the Resource Graph; minor color tweaks

commit d6e1737
Merge: 88054e5 6176ca2
Author: Charles Hacskaylo <[email protected]>
Date:   Mon Jul 18 10:29:32 2016 -0700

    [Frontend] Merge master into frontend-1047

    Fixes #1047
    Resolved conflict in icomoon.json file

commit 88054e5
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jun 30 16:55:40 2016 -0700

    [Frontend] Refactoring glyphs to classes

    fixes #1047
    In progress: significant mods to pane collapse/expand
    buttons and symbols, minor tweaks to splitter look,
    limits glyph definitions

commit 7c47343
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jun 30 16:52:21 2016 -0700

    [Frontend] Refactoring glyphs to classes

    fixes #1047
    In progress: updated font files glyphs, mostly
    for pane collapse icons

commit fd00bdc
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jun 30 12:20:55 2016 -0700

    [Frontend] Refactoring glyphs to classes

    fixes #1047
    In progress: search menu

commit 272b4b6
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jun 30 12:11:25 2016 -0700

    [Frontend] Refactoring glyphs to classes

    fixes #1047
    In progress: moved limits classes out
    of _contants and into _glyphs;
    timers, entanglement context menu items,
    form validation, date picker.

commit 95d26e6
Author: Charles Hacskaylo <[email protected]>
Date:   Wed Jun 29 14:18:12 2016 -0700

    [Frontend] Refactoring glyphs to classes

    Fixes #1047
    In-progress; limits

commit 26b30d9
Author: Charles Hacskaylo <[email protected]>
Date:   Tue Jun 28 17:16:18 2016 -0700

    [Frontend] Refactoring glyphs to classes

    Fixes #1047
    In-progress; overlay close, search inputs,
    messages and message banners,
    ui-symbol removal in-progress.

commit 4e2a01a
Author: Charles Hacskaylo <[email protected]>
Date:   Tue Jun 28 16:21:05 2016 -0700

    [Frontend] Refactoring glyphs to classes

    Fixes #1047
    In-progress; .labeled added  to .s-btn,
    removed .s-icon-btn

commit 521db3c
Author: Charles Hacskaylo <[email protected]>
Date:   Tue Jun 28 16:10:54 2016 -0700

    [Frontend] Refactoring glyphs to classes

    Fixes #1047
    In-progress; plot options, imagery buttons,
    cleanups in buttons.scss, edit-action buttons,
    .s-btn .no-label class added.

commit 8bb8db6
Author: Charles Hacskaylo <[email protected]>
Date:   Tue Jun 28 14:47:52 2016 -0700

    [Frontend] Refactoring glyphs to classes

    Fixes #1047
    In-progress; indicators, notifications, actions,
    tests

commit 53ed0bf
Author: Charles Hacskaylo <[email protected]>
Date:   Mon Jun 27 17:01:45 2016 -0700

    [Frontend] Refactoring glyphs to classes

    fixes #1047
    In progress, really: view icons, timer/clock

commit 47dc7f2
Author: Charles Hacskaylo <[email protected]>
Date:   Mon Jun 27 16:13:31 2016 -0700

    [Frontend] Refactoring glyphs to classes

    fixes #1047
    In progress: grid items

commit 2bd34f7
Author: Charles Hacskaylo <[email protected]>
Date:   Mon Jun 27 15:00:46 2016 -0700

    [Frontend] Refactoring glyphs to classes

    fixes #1047
    Context menus and associated actions,
    custom checkboxes, tree item being edited

commit b561d4f
Author: Charles Hacskaylo <[email protected]>
Date:   Mon Jun 27 14:27:56 2016 -0700

    [Frontend] Refactoring glyphs to classes

    fixes #1047
    In-progess: glyphs.scss now uses $vars to
    allow other scss to use a var instead of string
    literals;

commit 0cf4089
Author: Charles Hacskaylo <[email protected]>
Date:   Mon Jun 27 14:13:59 2016 -0700

    [Frontend] Refactoring glyphs to classes

    fixes #1047
    In-progess: tree-labels, unknown objects, object
    header

commit 46cae10
Author: Charles Hacskaylo <[email protected]>
Date:   Mon Jun 27 11:41:06 2016 -0700

    [Frontend] Refactoring glyphs to classes

    fixes #1047
    In-progess, menus and Create menu fixes

commit fe30977
Merge: 7d69ae4 652a50c
Author: Charles Hacskaylo <[email protected]>
Date:   Mon Jun 27 11:20:55 2016 -0700

    Merge remote-tracking branch 'origin/master' into frontend-1047

commit 7d69ae4
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jun 23 15:59:56 2016 -0700

    [Frontend] Refactoring glyphs to classes

    fixes #1047
    In-progress, converting types, mods to
    Create Menu template

commit 18d9f3d
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jun 23 15:14:22 2016 -0700

    [Frontend] Refactoring glyphs to classes

    fixes #1047
    Very much In-progess: convert some controls;

commit e93a90a
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jun 23 11:28:07 2016 -0700

    [Frontend] Refactoring glyphs to classes

    fixes #1047
    Very much In-progess, classes for all symbols
    added to glyphs.scss; .menu cleaned up;

commit dc670b2
Author: Charles Hacskaylo <[email protected]>
Date:   Thu Jun 23 08:55:27 2016 -0700

    [Frontend] Refactoring glyphs to classes

    fixes #1047
    Very much In-progess, "icon-" selector,
    browse bar buttons

commit 8b29ccf
Author: Charles Hacskaylo <[email protected]>
Date:   Wed Jun 22 23:15:24 2016 -0700

    [Frontend] Refactoring glyphs to classes

    fixes #1047
    Very much In-progess, s-btn and
    s-btn-menu refactoring

commit f574ffe
Author: Charles Hacskaylo <[email protected]>
Date:   Wed Jun 22 14:37:34 2016 -0700

    [Frontend] Refactoring glyphs to classes

    fixes #1047
    In-progess, e900 > e904

commit bc62ee4
Author: Charles Hacskaylo <[email protected]>
Date:   Wed Jun 22 13:28:15 2016 -0700

    [Frontend] Complete revamp of unicodes

    fixes #1047
    New font files; no re-mapping yet in the app.

commit 614f0c6
Author: Charles Hacskaylo <[email protected]>
Date:   Wed Jun 22 13:23:18 2016 -0700

    [Frontend] Complete revamp of unicodes

    fixes #1047
    Moved all glyphs into PUA area of font, and
    re-organized by category.

commit 47bd403
Author: Charles Hacskaylo <[email protected]>
Date:   Tue Jun 21 18:39:48 2016 -0700

    [Frontend] Renaming symbols font files

    Fixes #1047
    - Modified sass to point to renamed font files;
    - Added new 12px symbols font files to sass;

commit 22a51d6
Author: Charles Hacskaylo <[email protected]>
Date:   Tue Jun 21 18:22:33 2016 -0700

    [Frontend] Updating Icomoon project files

    Fixes #1047
    - Renamed main project file;
    - Added new 12px symbols project file;

commit 13ded2f
Author: Charles Hacskaylo <[email protected]>
Date:   Tue Jun 21 18:19:27 2016 -0700

    [Frontend] Added new 12px symbols font files

    Fixes #1047

commit aef5660
Author: Charles Hacskaylo <[email protected]>
Date:   Tue Jun 21 18:16:56 2016 -0700

    [Frontend] Renaming symbols font files

    Fixes #1047
@VWoeltjen
Copy link
Contributor

Squash-merged in d1e1ba1; closing this PR

@VWoeltjen VWoeltjen closed this Aug 1, 2016
@larkin larkin deleted the frontend-1047 branch April 27, 2017 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants