Skip to content

Commit

Permalink
[Frontend] Rename .s-menu-btn, remove unused
Browse files Browse the repository at this point in the history
Fixes #1047
.s-menu-btn > .s-menu-button;
.create-btn > .create-button;
removed unused l-btn, t-btn,
t-btns-zoom from markup
  • Loading branch information
charlesh88 committed Jul 28, 2016
1 parent 5d22919 commit 7bca18b
Show file tree
Hide file tree
Showing 15 changed files with 24 additions and 24 deletions.
2 changes: 1 addition & 1 deletion example/mobile/res/sass/mobile-example.scss
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

@include phoneandtablet {
// Show the Create button
.create-btn-holder {
.create-button-holder {
display: block !important;
}
}
2 changes: 1 addition & 1 deletion platform/commonUI/browse/res/templates/browse.html
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<div class="abs holder l-flex-col holder-treeview-elements">
<mct-representation key="'create-button'"
mct-object="navigatedObject"
class="holder flex-elem create-btn-holder">
class="holder flex-elem create-button-holder">
</mct-representation>
<mct-include key="'search'"
ng-model="treeModel"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
at runtime from the About dialog for additional information.
-->
<span ng-controller="ClickAwayController as createController">
<div class="s-menu-btn major create-btn" ng-click="createController.toggle()">
<div class="s-menu-button major create-button" ng-click="createController.toggle()">
<span class="title-label">Create</span>
</div>
<div class="menu super-menu" ng-show="createController.isActive()">
Expand Down
2 changes: 1 addition & 1 deletion platform/commonUI/general/res/sass/_icons.scss
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
display: inline-block;
}

.s-menu-btn .invoke-menu,
.s-menu-button .invoke-menu,
.icon.major .invoke-menu {
margin-left: $interiorMarginSm;
}
Expand Down
2 changes: 1 addition & 1 deletion platform/commonUI/general/res/sass/controls/_controls.scss
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ label.radio.custom {
label.checkbox.custom input:checked ~ em:before { content: $glyph-icon-check; }
label.radio.custom input:checked ~ em:before { content: $glyph-icon-bullet; }

.s-menu-btn label.checkbox.custom {
.s-menu-button label.checkbox.custom {
margin-left: 5px;
}

Expand Down
6 changes: 3 additions & 3 deletions platform/commonUI/general/res/sass/controls/_menus.scss
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
* at runtime from the About dialog for additional information.
*****************************************************************************/
/******************************************************** MENU BUTTONS */
.s-menu-btn {
.s-menu-button {
// Formerly .btn-menu
@extend .s-button;
span.l-click-area {
Expand Down Expand Up @@ -53,7 +53,7 @@
color: rgba($colorInvokeMenu, percentToDecimal($contrastInvokeMenuPercent));
}

&.create-btn {
&.create-button {
@extend .icon-plus;
.title-label {
font-size: 1rem;
Expand Down Expand Up @@ -122,7 +122,7 @@
.icon-menu,
.context-menu,
.super-menu,
.s-menu-btn .menu {
.s-menu-button .menu {
pointer-events: auto;
ul li {
a.menu-item-a {
Expand Down
2 changes: 1 addition & 1 deletion platform/commonUI/general/res/sass/mobile/_layout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ body.mobile {
}
}

.create-btn-holder {
.create-button-holder {
// Hide the create button by default in mobile;
// This can be overridden by the examples/mobile bundle
display: none;
Expand Down
4 changes: 2 additions & 2 deletions platform/commonUI/general/res/sass/user-environ/_frame.scss
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
}
&.frame-template {
.s-button,
.s-menu-btn {
.s-menu-button {
height: $ohH;
line-height: $ohH;
padding: 0 $interiorMargin;
Expand All @@ -60,7 +60,7 @@
}
}

.s-menu-btn:after {
.s-menu-button:after {
font-size: 8px;
}

Expand Down
8 changes: 4 additions & 4 deletions platform/commonUI/general/res/sass/user-environ/_layout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -192,11 +192,11 @@ body.desktop .pane .mini-tab-icon.toggle-pane {
right: 0;
bottom: $interiorMargin;
left: $bodyMargin;
.create-btn-holder {
.create-button-holder {
&.s-status-editing {
display: none;
& + .search-holder .search-bar {
// .search-holder is adjacent sibling to .create-btn-holder
// .search-holder is adjacent sibling to .create-button-holder
// Add right margin when create button is hidden, to make room for the collapse pane 'x' button
margin-right: $interiorMarginLg * 2;
}
Expand Down Expand Up @@ -239,9 +239,9 @@ body.desktop .pane .mini-tab-icon.toggle-pane {

.object-browse-bar .s-button,
.top-bar .buttons-main .s-button,
.top-bar .s-menu-btn,
.top-bar .s-menu-button,
.tool-bar .s-button,
.tool-bar .s-menu-btn {
.tool-bar .s-menu-button {
$h: $btnToolbarH;
height: $h;
line-height: $h;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
at runtime from the About dialog for additional information.
-->
<span ng-controller="ViewSwitcherController">
<div class="view-switcher menu-element s-menu-btn {{ngModel.selected.cssclass}}"
<div class="view-switcher menu-element s-menu-button {{ngModel.selected.cssclass}}"
ng-if="view.length > 1"
ng-controller="ClickAwayController as toggle">

Expand Down
2 changes: 1 addition & 1 deletion platform/features/plot/res/templates/plot.html
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
ng-show="plot.isZoomed()"
title="Reset pan/zoom">
</a>
<div class="menu-element s-menu-btn menus-to-left {{plot.getMode().cssclass}}"
<div class="menu-element s-menu-button menus-to-left {{plot.getMode().cssclass}}"
ng-if="plot.getModeOptions().length > 1"
ng-controller="ClickAwayController as toggle">
<span class="l-click-area" ng-click="toggle.toggle()"></span>
Expand Down
2 changes: 1 addition & 1 deletion platform/features/table/res/templates/mct-table.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<a class="t-btn l-btn s-button t-export icon-download labeled"
<a class="s-button t-export icon-download labeled"
ng-click="exportAsCSV()"
title="Export This View's Data">
Export
Expand Down
8 changes: 4 additions & 4 deletions platform/features/timeline/res/templates/timeline.html
Original file line number Diff line number Diff line change
Expand Up @@ -102,20 +102,20 @@

<!-- TOP PANE GANTT BARS -->
<div class="split-pane-component l-timeline-pane t-pane-h l-pane-top t-timeline-gantt l-timeline-gantt s-timeline-gantt">
<div class="l-hover-btns-holder s-hover-btns-holder t-btns-zoom">
<a class="t-btn l-btn s-button icon-arrows-out"
<div class="l-hover-btns-holder s-hover-btns-holder">
<a class="s-button icon-arrows-out"
ng-click="zoomController.fit()"
ng-show="true"
title="Zoom to fit">
</a>

<a class="t-btn l-btn s-button icon-magnify-in"
<a class="s-button icon-magnify-in"
ng-click="zoomController.zoom(-1)"
ng-show="true"
title="Zoom in">
</a>

<a class="t-btn l-btn s-button icon-magnify-out"
<a class="s-button icon-magnify-out"
ng-click="zoomController.zoom(1)"
ng-show="true"
title="Zoom out">
Expand Down
2 changes: 1 addition & 1 deletion platform/forms/res/templates/controls/color.html
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
this source code distribution or the Licensing information page available
at runtime from the About dialog for additional information.
-->
<div class="t-btn l-btn s-button s-menu-btn menu-element t-color-palette {{structure.cssclass}}"
<div class="s-button s-menu-button menu-element t-color-palette {{structure.cssclass}}"
ng-controller="ClickAwayController as toggle">

<span class="l-click-area" ng-click="toggle.toggle()"></span>
Expand Down
2 changes: 1 addition & 1 deletion platform/forms/res/templates/controls/menu-button.html
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
this source code distribution or the Licensing information page available
at runtime from the About dialog for additional information.
-->
<div class="s-menu-btn menu-element {{ structure.cssclass }}"
<div class="s-menu-button menu-element {{ structure.cssclass }}"
ng-controller="ClickAwayController as toggle">

<span class="l-click-area" ng-click="toggle.toggle()"></span>
Expand Down

0 comments on commit 7bca18b

Please sign in to comment.