Skip to content

Commit fd00bdc

Browse files
committed
[Frontend] Refactoring glyphs to classes
fixes #1047 In progress: search menu
1 parent 272b4b6 commit fd00bdc

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

platform/commonUI/general/res/sass/controls/_menus.scss

+2-1
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,8 @@
150150
}
151151
}
152152
}
153-
.type-icon {
153+
&:before {
154+
// Type icon
154155
left: 25px;
155156
}
156157
}

platform/search/res/templates/search-menu.html

+2-11
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,9 @@
2323
<div ng-controller="SearchMenuController as controller">
2424

2525
<div class="menu checkbox-menu">
26-
2726
<ul>
2827
<!-- First element is special - it's a reset option -->
29-
<li class="search-menu-item special"
28+
<li class="search-menu-item special icon-asterisk"
3029
title="Select all filters"
3130
ng-click="ngModel.checkAll = !ngModel.checkAll; controller.checkAll()">
3231

@@ -37,15 +36,11 @@
3736
ng-change="controller.checkAll()" />
3837
<em></em>
3938
</label>
40-
41-
<span class="ui-symbol icon type-icon">
42-
*
43-
</span>
4439
All
4540
</li>
4641

4742
<!-- The filter options, by type -->
48-
<li class="search-menu-item"
43+
<li class="search-menu-item {{ type.cssclass }}"
4944
ng-repeat="type in ngModel.types"
5045
ng-click="ngModel.checked[type.key] = !ngModel.checked[type.key]; controller.updateOptions()">
5146

@@ -56,10 +51,6 @@
5651
ng-change="controller.updateOptions()" />
5752
<em></em>
5853
</label>
59-
60-
<span class="ui-symbol icon type-icon">
61-
{{ type.glyph }}
62-
</span>
6354
{{ type.name }}
6455
</li>
6556
</ul>

0 commit comments

Comments
 (0)