Skip to content

Commit

Permalink
[Frontend] Refactoring Timeline glyphs, s-btn fixes
Browse files Browse the repository at this point in the history
Fixes #1047
WIP: Timeline-related glyph refactoring; s-btn
styles and hover color fixes
  • Loading branch information
charlesh88 committed Jul 21, 2016
1 parent 883f999 commit a4111f3
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 6 deletions.
5 changes: 3 additions & 2 deletions platform/commonUI/general/res/sass/_mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -316,8 +316,9 @@
@if $bgHovColor != none {
&:not(.disabled):hover {
background: $bgHovColor; // was just background, and background-image before that
>.icon {
color: lighten($ic, $ltGamma);
>.icon,
&:before {
color: pullForward($ic, $ltGamma);
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions platform/commonUI/general/res/sass/controls/_controls.scss
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@
.s-clickable-icon {
// Clickable icon elements that have hover
@extend .ui-symbol;
&:hover {
color: $colorKeyHov;
&.inactive:hover {
color: $colorBtnBgHov !important;
}
}

Expand Down
3 changes: 2 additions & 1 deletion platform/commonUI/themes/espresso/res/sass/_constants.scss
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,10 @@ $smallCr: 2px;
$colorBtnBg: pullForward($colorBodyBg, $contrastRatioPercent);
$colorBtnBgHov: pullForward($colorBtnBg, $hoverRatioPercent);
$colorBtnFg: $colorBodyFg;
$colorBtnFgHov: pullForward($colorBtnFg, $hoverRatioPercent);
$colorBtnMajorBg: $colorKey;
$colorBtnMajorFg: $colorKeyFg;
$colorBtnIcon: $colorKey;
$colorBtnIcon: $colorBtnFg;
$colorInvokeMenu: #fff;
$contrastInvokeMenuPercent: 20%;
$shdwBtns: rgba(black, 0.2) 0 1px 2px;
Expand Down
1 change: 1 addition & 0 deletions platform/commonUI/themes/snow/res/sass/_constants.scss
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ $smallCr: 3px;
$colorBtnBg: pullForward($colorBodyBg, $contrastRatioPercent);
$colorBtnBgHov: pullForward($colorBtnBg, $hoverRatioPercent);
$colorBtnFg: #fff;
$colorBtnFgHov: pullForward($colorBtnFg, $hoverRatioPercent);
$colorBtnMajorBg: $colorKey;
$colorBtnMajorFg: $colorKeyFg;
$colorBtnIcon: #eee;
Expand Down
2 changes: 1 addition & 1 deletion platform/features/timeline/res/sass/_timelines.scss
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@
color: $colorKey;
}
.t-toggle .inactive {
color: pullForward(rgba($colorBodyFg, 0.2));
color: $colorBtnBg;
}
}

Expand Down

0 comments on commit a4111f3

Please sign in to comment.