Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gauge plugin #4896

Closed
9 of 10 tasks
charlesh88 opened this issue Feb 24, 2022 · 9 comments · Fixed by #4919 or #5105
Closed
9 of 10 tasks

Add Gauge plugin #4896

charlesh88 opened this issue Feb 24, 2022 · 9 comments · Fixed by #4919 or #5105
Labels
type:enhancement

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Feb 24, 2022 •
edited by nikhilmandlik
Loading

Add radial Gauge plugin component.

Details from discussion 2/24/22 Andrew, Nikhil, Jamie, Charles:

@charlesh88 todos:

image

Other todos

  • Add support for lower and upper red limits as user-available options. If selected, use as min/max thresholds with something like 10% padding. If user doesn't select this option, the user should set manual min/max and min/max red limits. Use checkbox per min/max setting.
  • Keep settings in Properties dialog form (rather than Inspector) for now.
  • Bring inline with current code style and practices.
  • Add testing (?)

Future

  • Vertical and horizontal meter options. Needs design.
  • Needle option as an alternative to current "filled bar" visualization. Needs design.

Testing instructions:

  1. Verify new Gauge object with horizontal, Vertical, Needle and Filled bar visualization styles.
  2. Verify Gauge has edit mode and works as expected.
@charlesh88 charlesh88 changed the title Add Gauge Add Gauge plugin Feb 24, 2022
@nikhilmandlik nikhilmandlik mentioned this issue Mar 18, 2022
Merged
15 tasks
@unlikelyzero
Copy link
Contributor

@nikhilmandlik let's write out some testing instructions together and merge in some e2e stubs

@charlesh88
Copy link
Contributor Author

charlesh88 commented Mar 23, 2022 •
edited
Loading

Testing Notes

I've created a folder with Gauges, Sine Wave Generators and layouts that can be imported: Gauge Test.json.zip

Display Layout reference GIF

Gauge Test Layout

Flexible Layout reference GIF

Gauge Test Flexible Layout

  1. Create a series of Gauges, one for each type, and add them to a layout -- or import the attached file. We're looking to make sure that all 5 types of Gauge are displayed properly and perform as expected.
  2. Verify that each Gauge type - Dial Filled, Dial Needle, Meter Vertical, Meter Vertical Inverted and Meter Horizontal all appear the same as shown in the reference GIFs above.
  3. Edit properties of each gauge type, hiding and showing value and ranges, changing the Float Precision setting, and verify the gauge displays as expected. Note that Sine Wave Generators do not output more than 2 decimals of precision.
  4. Change the properties of the Sine Wave Generators and verify that the gauge updates itself accordingly.
  5. Edit the layout that holds the gauges, and verify that the gauge dynamically resizes itself as well as the ranges and current value display.
  6. In the Display Layout, hide the frames on a few of the gauges and verify that the gauge fills the space as expected.
  7. If possible (if testing on a server), test the gauge with sample telemetry as well.

@akhenry akhenry mentioned this issue Apr 22, 2022
Merged
15 tasks
@charlesh88
Copy link
Contributor Author

Verified NOT fixed Testathon 04-25-22: this view needs Edit mode to manage composition.

@akhenry
Copy link
Contributor

akhenry commented Apr 25, 2022

@nikhilmandlik How much work is involved in enabling edit mode for this?

@akhenry
Copy link
Contributor

akhenry commented Apr 25, 2022

@nikhilmandlik to enable edit mode

@akhenry akhenry reopened this Apr 25, 2022
nikhilmandlik added a commit that referenced this issue Apr 26, 2022
@nikhilmandlik
Add Gauge plugin #4896, add edit mode
ce8cfd8
shefalijoshi pushed a commit that referenced this issue Apr 26, 2022
@nikhilmandlik
Add Gauge plugin #4896, add edit mode (#5118)
d30c4fc 
* Add Gauge plugin #4896, add edit mode
@charlesh88 charlesh88 mentioned this issue Apr 27, 2022
Closed
akhenry pushed a commit that referenced this issue Apr 28, 2022
@nikhilmandlik
Gauge edit enabled 2.0.3 (#5133)
d7d06b5 
* Gauge plugin #4896, add edit mode
@jvigliotta
Copy link
Contributor

jvigliotta commented May 2, 2022 •
edited
Loading

OK... Not Fixed. There is an issue with telemetry that does not have limits, we're showing NaN...

Sizing looks good though.

@akhenry
Copy link
Contributor

akhenry commented May 2, 2022

Verified fixed

@akhenry
Copy link
Contributor

akhenry commented May 2, 2022

OK... Not Fixed. There is an issue with telemetry that does not have limits, we're showing NaN...

Let's file a followup issue to address this in 2.0.4

@unlikelyzero unlikelyzero mentioned this issue May 2, 2022
Closed
5 tasks
@unlikelyzero
Copy link
Contributor

#5155

shefalijoshi added a commit that referenced this issue May 3, 2022
@shefalijoshi @jvigliotta
@michaelrogers @davetsay @nikhilmandlik @charlesh88 @akhenry @johnhill2
2.0.3 merge to master (#5157)
c089a47 
* Release 2.0.3

* Fix tick values for plots ticks in log mode and null check (#5119)

* [2297] When there is no display range or range, skip setting the range value when auto scale is turned off.

* If the formatted value is a number and a float, set precision to 2 decimal points.

* Fix value assignment

* Use whole numbers in log mode

* Revert whole numbers fix - need floats for values between 0 and 1.

* Handle scrolling to focused image on resize/new data (#5121)

* Scroll to focused image when view resizes - this will force scrolling to focused image when going to/from view large mode

* Scroll to the right if there is no paused focused image

* [LAD Tables] Use Telemetry Collections (#5127)

* Use telemetry collections to handle bounds checks

* added telemetry collection to alphanumeric telemetry view (#5131)

* Added animation styling for POS and CAM; adjusted cutoff for isNewImage (#5116)

* Added animation styling for POS and CAM; adjusted cutoff for isNewImage

* Remove animation from POS and CAM

* Fix transactions overwriting latest objects with stale objects on save (#5132)

* use object (map) instead of set to track dirty objects
* fix tests due to internals change

Co-authored-by: Nikhil <[email protected]>

* Gauge edit enabled 2.0.3 (#5133)

* Gauge plugin #4896, add edit mode

* Dynamic dial-type Gauge sizing by height and width (#5129)

* Improve sizing strategy for gauges.
* Do not install gauge by default for now

Co-authored-by: Nikhil <[email protected]>
Co-authored-by: Jamie Vigliotta <[email protected]>
Co-authored-by: Andrew Henry <[email protected]>

* [Telemetry Collections] Include data with start and end bounds (#5145)

* Reverts forced precision for log plots axis labels (#5147)

* Condition Widgets trigger hundreds of persistence calls (#5146)

Co-authored-by: unlikelyzero <[email protected]>

Co-authored-by: Jamie V <[email protected]>
Co-authored-by: Michael Rogers <[email protected]>
Co-authored-by: David Tsay <[email protected]>
Co-authored-by: Nikhil <[email protected]>
Co-authored-by: Charles Hacskaylo <[email protected]>
Co-authored-by: Andrew Henry <[email protected]>
Co-authored-by: unlikelyzero <[email protected]>
shefalijoshi added a commit that referenced this issue Jun 9, 2022
@shefalijoshi @jvigliotta
@michaelrogers @davetsay @nikhilmandlik @charlesh88 @akhenry @johnhill2
2.0.4 merge into master (#5297)
0f0c6a7 
* Release 2.0.3

* Fix tick values for plots ticks in log mode and null check (#5119)

* [2297] When there is no display range or range, skip setting the range value when auto scale is turned off.

* If the formatted value is a number and a float, set precision to 2 decimal points.

* Fix value assignment

* Use whole numbers in log mode

* Revert whole numbers fix - need floats for values between 0 and 1.

* Handle scrolling to focused image on resize/new data (#5121)

* Scroll to focused image when view resizes - this will force scrolling to focused image when going to/from view large mode

* Scroll to the right if there is no paused focused image

* [LAD Tables] Use Telemetry Collections (#5127)

* Use telemetry collections to handle bounds checks

* added telemetry collection to alphanumeric telemetry view (#5131)

* Added animation styling for POS and CAM; adjusted cutoff for isNewImage (#5116)

* Added animation styling for POS and CAM; adjusted cutoff for isNewImage

* Remove animation from POS and CAM

* Fix transactions overwriting latest objects with stale objects on save (#5132)

* use object (map) instead of set to track dirty objects
* fix tests due to internals change

Co-authored-by: Nikhil <[email protected]>

* Gauge edit enabled 2.0.3 (#5133)

* Gauge plugin #4896, add edit mode

* Dynamic dial-type Gauge sizing by height and width (#5129)

* Improve sizing strategy for gauges.
* Do not install gauge by default for now

Co-authored-by: Nikhil <[email protected]>
Co-authored-by: Jamie Vigliotta <[email protected]>
Co-authored-by: Andrew Henry <[email protected]>

* [Telemetry Collections] Include data with start and end bounds (#5145)

* Reverts forced precision for log plots axis labels (#5147)

* Condition Widgets trigger hundreds of persistence calls (#5146)

Co-authored-by: unlikelyzero <[email protected]>

* Update version for 2.0.4 (#5255)

* Eliminate NaN conditions and clear stale duration (#5248)

* Temp source map fix 2.0.4 (#5267)

* use dev mode for production

* mode -> production

* added extra devtool options

* wip

* Imagery Fixes for release/2.0.4 (#5282)

* Fallback for height

* Remove duplicated requestHistory call since setDataTimeContext already invokes it on mount

* Inverted datumIsNotValid and refactored requestHistory

* Remove old datumIsNotValid func

* Return false if datum is falsy

* Corrected brightness/contrast input

* Clone default values to avoid mutation

* Changed index of imageTelemetry to an item within bounds

* Implement clearData test for imagery differently

* x-out clearData tests

Co-authored-by: Joshi <[email protected]>

* Imagery test fixes (#5293)

* Fallback for height

* Remove duplicated requestHistory call since setDataTimeContext already invokes it on mount

* Inverted datumIsNotValid and refactored requestHistory

* Remove old datumIsNotValid func

* Return false if datum is falsy

* Corrected brightness/contrast input

* Clone default values to avoid mutation

* Changed index of imageTelemetry to an item within bounds

* Implement clearData test for imagery differently

* x-out clearData tests

* Set bounds on each test rather than the wrapper

Co-authored-by: Michael Rogers <[email protected]>

* Imagery validation fix (#5295)

* Remove check for duplicate images
* Remove commented out code and add TODO

* lint fix

* Add missing tests

* Use the master version and ignore release/2.0.4 changes

Co-authored-by: Jamie V <[email protected]>
Co-authored-by: Michael Rogers <[email protected]>
Co-authored-by: David Tsay <[email protected]>
Co-authored-by: Nikhil <[email protected]>
Co-authored-by: Charles Hacskaylo <[email protected]>
Co-authored-by: Andrew Henry <[email protected]>
Co-authored-by: unlikelyzero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add gauge 4896 nasa/openmct
Delete gauge.e2eSpec.js nasa/openmct
6 participants
@charlesh88 @nikhilmandlik @akhenry @shefalijoshi @jvigliotta @unlikelyzero