Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gauge Plugin] Limits and Composition Issues #5155

Closed
2 of 5 tasks
unlikelyzero opened this issue May 2, 2022 · 1 comment · Fixed by #5156
Closed
2 of 5 tasks

[Gauge Plugin] Limits and Composition Issues #5155

unlikelyzero opened this issue May 2, 2022 · 1 comment · Fixed by #5156
Labels
needs:e2e Needs an e2e test severity:critical type:bug
Milestone
Target:2.0.5

Comments

@unlikelyzero
Copy link
Contributor

unlikelyzero commented May 2, 2022 •
edited by nikhilmandlik
Loading

(#4896 (comment))

Think this is related to #5139 as well

Summary

When you add a telemetry item, that does not have set limits and you do not have manually set limits on the gauge property, "NaN" will show where the min and max limits should or should not.

Also, if you remove an item from the gauge (via the tree or the elements pool), then the gauge itself will still show the value from the telemetry item. This can be fixed by navigating away and returning or refreshing.

Expected vs Current Behavior

Steps to Reproduce

Testing instructions

  1. Add a telemetry item without limits provided to a gauge (note, NaN is displayed for min/max values)
  2. Remove a telemetry item from a gauge (via tree or elements pool (note, the value of the telemetry is still displayed

Environment

Version: 2.0.3
Build Date: Mon May 02 2022 15:46:20 GMT-0700 (Pacific Daylight Time)
Revision: 663f42a
Branch: release/2.0.3

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?

Additional Information
@unlikelyzero unlikelyzero mentioned this issue May 2, 2022
Closed
10 tasks
@jvigliotta jvigliotta changed the title [jamie to file] [Gauge Plugin] Limits and Composition Issues May 3, 2022
nikhilmandlik added a commit that referenced this issue May 3, 2022
@nikhilmandlik
[Gauge Plugin] Limits and Composition Issues #5155
31bc0ba
@nikhilmandlik nikhilmandlik mentioned this issue May 3, 2022
Merged
15 tasks
nikhilmandlik added a commit that referenced this issue May 3, 2022
@nikhilmandlik
[Gauge Plugin] Limits and Composition Issues #5155
fb14041
nikhilmandlik added a commit that referenced this issue May 3, 2022
@nikhilmandlik
[Gauge Plugin] Limits and Composition Issues #5155
56bd399
jvigliotta pushed a commit that referenced this issue May 20, 2022
@nikhilmandlik
Gauge limits (#5156)
9f9c69e 
* Fix tick values for plots ticks in log mode and null check (#5119)
* [2297] When there is no display range or range, skip setting the range value when auto scale is turned off.
* If the formatted value is a number and a float, set precision to 2 decimal points.
* Fix value assignment
* Use whole numbers in log mode
* Revert whole numbers fix - need floats for values between 0 and 1.
* Reverts forced precision for log plots axis labels (#5147)
* [Gauge Plugin] Limits and Composition Issues #5155
* default current value as '--'
* updated as per review comments.
Co-authored-by: Shefali Joshi <[email protected]>
Co-authored-by: Andrew Henry <[email protected]>
@shefalijoshi
Copy link
Contributor

Verified Fixed

@unlikelyzero unlikelyzero added the needs:e2e Needs an e2e test label Jul 17, 2022
@unlikelyzero unlikelyzero added this to the Sprint:2.0.7 milestone Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs:e2e Needs an e2e test severity:critical type:bug
Projects
None yet
Milestone
Target:2.0.5
Development

Successfully merging a pull request may close this issue.

Gauge limits nasa/openmct
3 participants
@shefalijoshi @jvigliotta @unlikelyzero