2.0.4 merge into master #5297
Merged
2.0.4 merge into master #5297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [2297] When there is no display range or range, skip setting the range value when auto scale is turned off. * If the formatted value is a number and a float, set precision to 2 decimal points. * Fix value assignment * Use whole numbers in log mode * Revert whole numbers fix - need floats for values between 0 and 1.
* Scroll to focused image when view resizes - this will force scrolling to focused image when going to/from view large mode * Scroll to the right if there is no paused focused image
* Use telemetry collections to handle bounds checks
…ge (#5116) * Added animation styling for POS and CAM; adjusted cutoff for isNewImage * Remove animation from POS and CAM
#5132) * use object (map) instead of set to track dirty objects * fix tests due to internals change Co-authored-by: Nikhil <[email protected]>
* Gauge plugin #4896, add edit mode
* Improve sizing strategy for gauges. * Do not install gauge by default for now Co-authored-by: Nikhil <[email protected]> Co-authored-by: Jamie Vigliotta <[email protected]> Co-authored-by: Andrew Henry <[email protected]>
Co-authored-by: unlikelyzero <[email protected]>
* use dev mode for production * mode -> production * added extra devtool options * wip
* Fallback for height * Remove duplicated requestHistory call since setDataTimeContext already invokes it on mount * Inverted datumIsNotValid and refactored requestHistory * Remove old datumIsNotValid func * Return false if datum is falsy * Corrected brightness/contrast input * Clone default values to avoid mutation * Changed index of imageTelemetry to an item within bounds * Implement clearData test for imagery differently * x-out clearData tests Co-authored-by: Joshi <[email protected]>
* Fallback for height * Remove duplicated requestHistory call since setDataTimeContext already invokes it on mount * Inverted datumIsNotValid and refactored requestHistory * Remove old datumIsNotValid func * Return false if datum is falsy * Corrected brightness/contrast input * Clone default values to avoid mutation * Changed index of imageTelemetry to an item within bounds * Implement clearData test for imagery differently * x-out clearData tests * Set bounds on each test rather than the wrapper Co-authored-by: Michael Rogers <[email protected]>
* Remove check for duplicate images * Remove commented out code and add TODO
unlikelyzero
reviewed
Jun 7, 2022
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "openmct", | |||
| "version": "2.0.3-SNAPSHOT", | |||
| "version": "2.0.4", | |||
There was a problem hiding this comment.
this needs to be updated, right?
There was a problem hiding this comment.
Yes, waiting to resolve conflicts.
Codecov Report
@@ Coverage Diff @@
## master #5297 +/- ##
==========================================
- Coverage 49.71% 49.71% -0.01%
==========================================
Files 589 589
Lines 21569 21563 -6
Branches 2018 2020 +2
==========================================
- Hits 10722 10719 -3
+ Misses 10312 10307 -5
- Partials 535 537 +2
Continue to review full report at Codecov.
|
unlikelyzero
reviewed
Jun 8, 2022
unlikelyzero
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Merges 2.0.4 into master
All Submissions:
Author Checklist
Reviewer Checklist