Handle scrolling to focused image on resize/new data #5121

shefalijoshi · 2022-04-26T21:29:35Z

Describe your changes:

Scroll to focused image when view resizes - this will force scrolling to focused image when going to/from view large mode

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

Changes address original issue?
Unit tests included and/or updated with changes?
Command line build passes?
Has this been smoke tested?
Testing instructions included in associated issue?

Reviewer Checklist

Changes appear to address issue?
Changes appear not to be breaking changes?
Appropriate unit tests included?
Code style and in-line documentation are appropriate?
Commit messages meet standards?
Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

… to focused image when going to/from view large mode

codecov · 2022-04-26T21:33:36Z

Codecov Report

❗ No coverage uploaded for pull request base (release/2.0.3@378a4ca). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/2.0.3    #5121   +/-   ##
================================================
  Coverage                 ?   49.88%           
================================================
  Files                    ?      533           
  Lines                    ?    19512           
  Branches                 ?     1758           
================================================
  Hits                     ?     9733           
  Misses                   ?     9334           
  Partials                 ?      445

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 378a4ca...a4e0472. Read the comment docs.

akhenry · 2022-04-26T22:30:59Z

This fix looks good to me. I think we need to answer #4850 (comment) before we merge though.

shefalijoshi · 2022-04-28T03:08:16Z

@akhenry I think we're good to merge.

akhenry · 2022-04-28T17:44:18Z

Looks good to me, thanks.

* Scroll to focused image when view resizes - this will force scrolling to focused image when going to/from view large mode * Scroll to the right if there is no paused focused image

* Release 2.0.3 * Fix tick values for plots ticks in log mode and null check (#5119) * [2297] When there is no display range or range, skip setting the range value when auto scale is turned off. * If the formatted value is a number and a float, set precision to 2 decimal points. * Fix value assignment * Use whole numbers in log mode * Revert whole numbers fix - need floats for values between 0 and 1. * Handle scrolling to focused image on resize/new data (#5121) * Scroll to focused image when view resizes - this will force scrolling to focused image when going to/from view large mode * Scroll to the right if there is no paused focused image * [LAD Tables] Use Telemetry Collections (#5127) * Use telemetry collections to handle bounds checks * added telemetry collection to alphanumeric telemetry view (#5131) * Added animation styling for POS and CAM; adjusted cutoff for isNewImage (#5116) * Added animation styling for POS and CAM; adjusted cutoff for isNewImage * Remove animation from POS and CAM * Fix transactions overwriting latest objects with stale objects on save (#5132) * use object (map) instead of set to track dirty objects * fix tests due to internals change Co-authored-by: Nikhil <[email protected]> * Gauge edit enabled 2.0.3 (#5133) * Gauge plugin #4896, add edit mode * Dynamic dial-type Gauge sizing by height and width (#5129) * Improve sizing strategy for gauges. * Do not install gauge by default for now Co-authored-by: Nikhil <[email protected]> Co-authored-by: Jamie Vigliotta <[email protected]> Co-authored-by: Andrew Henry <[email protected]> * [Telemetry Collections] Include data with start and end bounds (#5145) * Reverts forced precision for log plots axis labels (#5147) * Condition Widgets trigger hundreds of persistence calls (#5146) Co-authored-by: unlikelyzero <[email protected]> Co-authored-by: Jamie V <[email protected]> Co-authored-by: Michael Rogers <[email protected]> Co-authored-by: David Tsay <[email protected]> Co-authored-by: Nikhil <[email protected]> Co-authored-by: Charles Hacskaylo <[email protected]> Co-authored-by: Andrew Henry <[email protected]> Co-authored-by: unlikelyzero <[email protected]>

* Release 2.0.3 * Fix tick values for plots ticks in log mode and null check (#5119) * [2297] When there is no display range or range, skip setting the range value when auto scale is turned off. * If the formatted value is a number and a float, set precision to 2 decimal points. * Fix value assignment * Use whole numbers in log mode * Revert whole numbers fix - need floats for values between 0 and 1. * Handle scrolling to focused image on resize/new data (#5121) * Scroll to focused image when view resizes - this will force scrolling to focused image when going to/from view large mode * Scroll to the right if there is no paused focused image * [LAD Tables] Use Telemetry Collections (#5127) * Use telemetry collections to handle bounds checks * added telemetry collection to alphanumeric telemetry view (#5131) * Added animation styling for POS and CAM; adjusted cutoff for isNewImage (#5116) * Added animation styling for POS and CAM; adjusted cutoff for isNewImage * Remove animation from POS and CAM * Fix transactions overwriting latest objects with stale objects on save (#5132) * use object (map) instead of set to track dirty objects * fix tests due to internals change Co-authored-by: Nikhil <[email protected]> * Gauge edit enabled 2.0.3 (#5133) * Gauge plugin #4896, add edit mode * Dynamic dial-type Gauge sizing by height and width (#5129) * Improve sizing strategy for gauges. * Do not install gauge by default for now Co-authored-by: Nikhil <[email protected]> Co-authored-by: Jamie Vigliotta <[email protected]> Co-authored-by: Andrew Henry <[email protected]> * [Telemetry Collections] Include data with start and end bounds (#5145) * Reverts forced precision for log plots axis labels (#5147) * Condition Widgets trigger hundreds of persistence calls (#5146) Co-authored-by: unlikelyzero <[email protected]> * Update version for 2.0.4 (#5255) * Eliminate NaN conditions and clear stale duration (#5248) * Temp source map fix 2.0.4 (#5267) * use dev mode for production * mode -> production * added extra devtool options * wip * Imagery Fixes for release/2.0.4 (#5282) * Fallback for height * Remove duplicated requestHistory call since setDataTimeContext already invokes it on mount * Inverted datumIsNotValid and refactored requestHistory * Remove old datumIsNotValid func * Return false if datum is falsy * Corrected brightness/contrast input * Clone default values to avoid mutation * Changed index of imageTelemetry to an item within bounds * Implement clearData test for imagery differently * x-out clearData tests Co-authored-by: Joshi <[email protected]> * Imagery test fixes (#5293) * Fallback for height * Remove duplicated requestHistory call since setDataTimeContext already invokes it on mount * Inverted datumIsNotValid and refactored requestHistory * Remove old datumIsNotValid func * Return false if datum is falsy * Corrected brightness/contrast input * Clone default values to avoid mutation * Changed index of imageTelemetry to an item within bounds * Implement clearData test for imagery differently * x-out clearData tests * Set bounds on each test rather than the wrapper Co-authored-by: Michael Rogers <[email protected]> * Imagery validation fix (#5295) * Remove check for duplicate images * Remove commented out code and add TODO * lint fix * Add missing tests * Use the master version and ignore release/2.0.4 changes Co-authored-by: Jamie V <[email protected]> Co-authored-by: Michael Rogers <[email protected]> Co-authored-by: David Tsay <[email protected]> Co-authored-by: Nikhil <[email protected]> Co-authored-by: Charles Hacskaylo <[email protected]> Co-authored-by: Andrew Henry <[email protected]> Co-authored-by: unlikelyzero <[email protected]>

Scroll to focused image when view resizes - this will force scrolling…

e4f72f3

… to focused image when going to/from view large mode

shefalijoshi requested review from charlesh88 and akhenry April 26, 2022 21:29

Scroll to the right if there is no paused focused image

a4e0472

akhenry approved these changes Apr 28, 2022

View reviewed changes

akhenry merged commit ce28dd2 into release/2.0.3 Apr 28, 2022

akhenry deleted the fix-imagery-scroll-position branch April 28, 2022 17:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle scrolling to focused image on resize/new data #5121

Handle scrolling to focused image on resize/new data #5121

shefalijoshi commented Apr 26, 2022 •

edited by akhenry

Loading

codecov bot commented Apr 26, 2022 •

edited

Loading

akhenry commented Apr 26, 2022

shefalijoshi commented Apr 28, 2022

akhenry commented Apr 28, 2022

Handle scrolling to focused image on resize/new data #5121

Handle scrolling to focused image on resize/new data #5121

Conversation

shefalijoshi commented Apr 26, 2022 • edited by akhenry Loading

Describe your changes:

All Submissions:

Author Checklist

Reviewer Checklist

codecov bot commented Apr 26, 2022 • edited Loading

Codecov Report

akhenry commented Apr 26, 2022

shefalijoshi commented Apr 28, 2022

akhenry commented Apr 28, 2022

shefalijoshi commented Apr 26, 2022 •

edited by akhenry

Loading

codecov bot commented Apr 26, 2022 •

edited

Loading