-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http.active.requests and http.duration metrics #227
Merged
jfallows
merged 9 commits into
aklivity:feature/telemetry-metrics
from
attilakreiner:metrics-http
May 9, 2023
Merged
Add http.active.requests and http.duration metrics #227
jfallows
merged 9 commits into
aklivity:feature/telemetry-metrics
from
attilakreiner:metrics-http
May 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
May 3, 2023
...livity/zilla/runtime/exporter/prometheus/internal/descriptor/PrometheusMetricDescriptor.java
Outdated
Show resolved
Hide resolved
...in/java/io/aklivity/zilla/runtime/metrics/http/internal/HttpActiveRequestsMetricContext.java
Outdated
Show resolved
Hide resolved
...in/java/io/aklivity/zilla/runtime/metrics/http/internal/HttpActiveRequestsMetricContext.java
Outdated
Show resolved
Hide resolved
...in/java/io/aklivity/zilla/runtime/metrics/http/internal/HttpActiveRequestsMetricContext.java
Outdated
Show resolved
Hide resolved
...in/java/io/aklivity/zilla/runtime/metrics/http/internal/HttpActiveRequestsMetricContext.java
Outdated
Show resolved
Hide resolved
...in/java/io/aklivity/zilla/runtime/metrics/http/internal/HttpActiveRequestsMetricContext.java
Show resolved
Hide resolved
...in/java/io/aklivity/zilla/runtime/metrics/http/internal/HttpActiveRequestsMetricContext.java
Outdated
Show resolved
Hide resolved
...or/metrics-http/src/main/java/io/aklivity/zilla/runtime/metrics/http/internal/HttpUtils.java
Outdated
Show resolved
Hide resolved
...or/metrics-http/src/main/java/io/aklivity/zilla/runtime/metrics/http/internal/HttpUtils.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
May 5, 2023
...src/main/java/io/aklivity/zilla/runtime/metrics/http/internal/HttpDurationMetricContext.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/aklivity/zilla/runtime/metrics/http/internal/HttpDurationMetricContext.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/aklivity/zilla/runtime/metrics/http/internal/HttpDurationMetricContext.java
Show resolved
Hide resolved
jfallows
requested changes
May 6, 2023
...in/java/io/aklivity/zilla/runtime/metrics/http/internal/HttpActiveRequestsMetricContext.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/aklivity/zilla/runtime/metrics/http/internal/HttpDurationMetricContext.java
Outdated
Show resolved
Hide resolved
jfallows
reviewed
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we need to adjust the line:
To use the following instead:
final MessageConsumer replyTo = supplyReplyTo(initialId).andThen(sentMetricHandler);
because these lines fill in the timestamp during writing of frames, such as END frame.
so that needs to be done first, before metrics try to observe the timestamp value, otherwise it will show timestamp value 0
.
jfallows
requested changes
May 9, 2023
...src/main/java/io/aklivity/zilla/runtime/metrics/http/internal/HttpDurationMetricContext.java
Outdated
Show resolved
Hide resolved
jfallows
approved these changes
May 9, 2023
jfallows
added a commit
that referenced
this pull request
May 12, 2023
* Add stream metrics spec and impl projects * Add http metrics spec and impl projects * Add metrics modules to incubator docker image * Metrics schema, extensibility, storage and command line support (#173) * Create incubator projects for exporter-prometheus.spec and exporter-prometheus * Engine support to exporters (#202) * Fix metrics command, find layout files in the engine dir (#204) * Prometheus Exporter (#203) * Minimize performance overhead for metric collection (#217) * Remove zilla load command (#223) * Introducing Stream Direction to Optimize Metric Collection (#224) * Add http.active.requests and http.duration metrics (#227) --------- Co-authored-by: Attila Kreiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds these metrics:
http.active.requests
to track the number of currently active http requests (gauge)http.duration
to track to track the duration of http requests (histogram)Fixes #111