Introducing Stream Direction to Optimize Metric Collection #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attilakreiner
force-pushed
the
stream-direction
branch
from
eb57a48 to
362902e
Compare
jfallows
requested changes
Apr 27, 2023
...e/engine/src/main/java/io/aklivity/zilla/runtime/engine/internal/registry/DispatchAgent.java
Outdated
Show resolved
Hide resolved
.../engine/src/main/java/io/aklivity/zilla/runtime/engine/internal/registry/MetricRegistry.java
Show resolved
Hide resolved
| if (direction == RECEIVED || direction == BOTH) | ||
| { | ||
| receivedOriginMetricHandler = receivedOriginMetricHandler.andThen(handler); | ||
| } |
There was a problem hiding this comment.
I feel like there should be a simpler way to handle this than nested if-else, but it works. 🙂
There was a problem hiding this comment.
Yeah, unfortunately it looks like this, but I don't exactly see a better way. We could introduce a map, but we have two keys so it should be something like Map<Direction, Map<MetricHandlerKind, MessageConsumer>> so I am not sure it would be actually simpler. 🤔
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/metrics/Metric.java
Outdated
Show resolved
Hide resolved
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/metrics/MetricContext.java
Show resolved
Hide resolved
attilakreiner
changed the title
jfallows
requested changes
Apr 28, 2023
...rics-http/src/main/java/io/aklivity/zilla/runtime/metrics/http/internal/HttpSizeHandler.java
Outdated
Show resolved
Hide resolved
...nding-tcp/src/test/java/io/aklivity/zilla/runtime/binding/tcp/internal/streams/ClientIT.java
Outdated
Show resolved
Hide resolved
jfallows
approved these changes
May 2, 2023
jfallows
added a commit
that referenced
this pull request
May 12, 2023
* Add stream metrics spec and impl projects * Add http metrics spec and impl projects * Add metrics modules to incubator docker image * Metrics schema, extensibility, storage and command line support (#173) * Create incubator projects for exporter-prometheus.spec and exporter-prometheus * Engine support to exporters (#202) * Fix metrics command, find layout files in the engine dir (#204) * Prometheus Exporter (#203) * Minimize performance overhead for metric collection (#217) * Remove zilla load command (#223) * Introducing Stream Direction to Optimize Metric Collection (#224) * Add http.active.requests and http.duration metrics (#227) --------- Co-authored-by: Attila Kreiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change reduces the performance overhead of the metric collection. All the metrics that we currently have operate exclusively either on received or on sent streams. It makes sense to add the stream direction as a property so that the engine should only call the necessary metrics when processing the received vs sent streams. We will soon have metrics that process both streams, so there is an option for that, too:
This also clears up some code duplication as the current received vs sent metric pairs have identical implementation when the stream direction check is removed, so the common logic is extracted to
*Contextand*Handlerclasses.It depends on PR #223.