Prometheus Exporter #203
Merged
Prometheus Exporter #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attilakreiner
force-pushed
the
exporter-prometheus
branch
5 times, most recently
from
d547634 to
ec13f37
Compare
attilakreiner
force-pushed
the
exporter-prometheus
branch
from
ec13f37 to
6c1dc7d
Compare
attilakreiner
force-pushed
the
exporter-prometheus
branch
from
d48e3aa to
d9ae4a4
Compare
attilakreiner
force-pushed
the
exporter-prometheus
branch
from
d9ae4a4 to
c22aaf3
Compare
jfallows
requested changes
Apr 18, 2023
...main/java/io/aklivity/zilla/runtime/exporter/prometheus/internal/config/EndpointAdapter.java
Outdated
Show resolved
Hide resolved
.../main/java/io/aklivity/zilla/runtime/exporter/prometheus/internal/config/EndpointConfig.java
Outdated
Show resolved
Hide resolved
...livity/zilla/runtime/exporter/prometheus/internal/descriptor/PrometheusMetricDescriptor.java
Outdated
Show resolved
Hide resolved
.../java/io/aklivity/zilla/runtime/exporter/prometheus/internal/processor/MetricsProcessor.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private String histogramFormatter( | ||
| String[] s, |
There was a problem hiding this comment.
Need a better parameter name, or split into namespace and binding.
There was a problem hiding this comment.
So, I expanded String[] s to String metric, String namespace, String binding, and for consistency I did the same for private String counterGaugeFormatter. Now I ended up having to create some funky named typed interfaces 😎 QuintFunction and Object3LongFunction. Pls check.
...main/java/io/aklivity/zilla/runtime/exporter/prometheus/internal/record/HistogramRecord.java
Outdated
Show resolved
Hide resolved
...io/aklivity/zilla/runtime/exporter/prometheus/internal/utils/ObjectObjectObjectFunction.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/aklivity/zilla/runtime/exporter/prometheus/internal/labels/LabelManager.java
Outdated
Show resolved
Hide resolved
...n/java/io/aklivity/zilla/runtime/exporter/prometheus/internal/PrometheusExporterHandler.java
Show resolved
Hide resolved
| metrics.print(out); | ||
| try | ||
| { | ||
| output = os.toString("UTF8"); |
There was a problem hiding this comment.
This is triggering plenty of object allocation, so we'll take another pass on that after these changes.
jfallows
requested changes
Apr 19, 2023
...n/java/io/aklivity/zilla/runtime/exporter/prometheus/internal/PrometheusExporterContext.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/exporter/prometheus/internal/config/PrometheusEndpointConfig.java
Outdated
Show resolved
Hide resolved
...ain/java/io/aklivity/zilla/runtime/exporter/prometheus/internal/processor/LayoutManager.java
Outdated
Show resolved
Hide resolved
.../java/io/aklivity/zilla/runtime/exporter/prometheus/internal/processor/MetricsProcessor.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Apr 20, 2023
...io/aklivity/zilla/runtime/exporter/prometheus/internal/config/PrometheusEndpointAdapter.java
Outdated
Show resolved
Hide resolved
...main/scripts/io/aklivity/zilla/specs/exporter/prometheus/schema/prometheus.schema.patch.json
Show resolved
Hide resolved
| }, | ||
| "additionalProperties": false | ||
| }, | ||
| "maxItems": 1 |
There was a problem hiding this comment.
Let's remove this, and spin up multiple HttpServer instances, one per endpoint.
In practice folks may only use one anyway, but this will keep the door open in case they have some requirement for http and https or something, plus less confusing when we attempt to document.
Btw, for https to work, we need to make sure the server certificate chain and key is configured, probably via vault.
jfallows
approved these changes
Apr 21, 2023
jfallows
added a commit
that referenced
this pull request
May 12, 2023
* Add stream metrics spec and impl projects * Add http metrics spec and impl projects * Add metrics modules to incubator docker image * Metrics schema, extensibility, storage and command line support (#173) * Create incubator projects for exporter-prometheus.spec and exporter-prometheus * Engine support to exporters (#202) * Fix metrics command, find layout files in the engine dir (#204) * Prometheus Exporter (#203) * Minimize performance overhead for metric collection (#217) * Remove zilla load command (#223) * Introducing Stream Direction to Optimize Metric Collection (#224) * Add http.active.requests and http.duration metrics (#227) --------- Co-authored-by: Attila Kreiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.