Minimize performance overhead for metric collection #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
approved these changes
Apr 21, 2023
jfallows
added a commit
that referenced
this pull request
May 12, 2023
* Add stream metrics spec and impl projects * Add http metrics spec and impl projects * Add metrics modules to incubator docker image * Metrics schema, extensibility, storage and command line support (#173) * Create incubator projects for exporter-prometheus.spec and exporter-prometheus * Engine support to exporters (#202) * Fix metrics command, find layout files in the engine dir (#204) * Prometheus Exporter (#203) * Minimize performance overhead for metric collection (#217) * Remove zilla load command (#223) * Introducing Stream Direction to Optimize Metric Collection (#224) * Add http.active.requests and http.duration metrics (#227) --------- Co-authored-by: Attila Kreiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chaining MessageConsumers and MetricHandlers allows optimal composition of metrics and stream handlers, with zero overhead when no metrics are collected, and minimal overhead when metrics are collected.
Fix #213