-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Aborts] Abort Telemetry Collections requests on Navigation, Add abort functionality to getLimits #6872
Conversation
… catch cases where the UI is bogged down and doesnt destroy the tc first
Mergin abort related PRs
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/24/2023 09:17:41pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 23937a1 Started: 08/24/2023 09:15:18pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Persistence operations @couchdb Can create an object after a conflict error @couchdb @2p
Retry 1 • Initial Attempt |
0% (0)0 / 37 runsfailed over last 7 days |
5.41% (2)2 / 37 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 136 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 08/24/2023 09:17:41pm UTC)
⚠️ Flakes
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
2.56% (2)2 / 78 runsfailed over last 7 days |
39.74% (31)31 / 78 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6872 +/- ##
=======================================
Coverage 48.30% 48.31%
=======================================
Files 643 643
Lines 25721 25729 +8
Branches 2512 2512
=======================================
+ Hits 12424 12430 +6
- Misses 12815 12817 +2
Partials 482 482
*This pull request uses carry forward flags. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Closes #6871
Related akhenry/openmct-yamcs#350
Describe your changes:
Added abort on nav to historical requests in Telemetry Collections.
Added abort capabilities to "getLimits" in the Telemetry API.
All Submissions:
Author Checklist
Reviewer Checklist