Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aborts] Abort Telemetry Collections requests on Navigation, Add abort functionality to getLimits #6872

Merged
merged 12 commits into from
Aug 24, 2023

Conversation

jvigliotta
Copy link
Contributor

Closes #6871
Related akhenry/openmct-yamcs#350

Describe your changes:

Added abort on nav to historical requests in Telemetry Collections.
Added abort capabilities to "getLimits" in the Telemetry API.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Aug 1, 2023

Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/24/2023 09:17:41pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 23937a1

Started: 08/24/2023 09:15:18pm UTC

⚠️ Flakes

📄   functional/forms.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Persistence operations @couchdb Can create an object after a conflict error @couchdb @2p
Retry 1Initial Attempt
0% (0) 0 / 37 runs
failed over last 7 days
5.41% (2) 2 / 37 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 136 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/24/2023 09:17:41pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 23937a1

Started: 08/22/2023 06:50:23pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
2.56% (2) 2 / 78 runs
failed over last 7 days
39.74% (31) 31 / 78 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #6872 (23937a1) into master (42b13c4) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master    #6872   +/-   ##
=======================================
  Coverage   48.30%   48.31%           
=======================================
  Files         643      643           
  Lines       25721    25729    +8     
  Branches     2512     2512           
=======================================
+ Hits        12424    12430    +6     
- Misses      12815    12817    +2     
  Partials      482      482           
Flag Coverage Δ *Carryforward flag
e2e-full 41.98% <ø> (-0.01%) ⬇️ Carriedforward from 42b13c4
e2e-stable 57.22% <66.66%> (+0.01%) ⬆️
unit 38.66% <0.00%> (-0.02%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
src/api/telemetry/TelemetryAPI.js 88.88% <66.66%> (-1.02%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b13c4...23937a1. Read the comment docs.

@akhenry akhenry self-requested a review August 1, 2023 20:58
@ozyx ozyx added this to the Target:3.0.1 milestone Aug 2, 2023
@jvigliotta jvigliotta requested a review from akhenry August 22, 2023 18:12
@shefalijoshi shefalijoshi self-requested a review August 22, 2023 18:35
@akhenry akhenry removed their request for review August 24, 2023 20:15
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 24, 2023
@ozyx ozyx enabled auto-merge (squash) August 24, 2023 21:14
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 24, 2023
@ozyx ozyx merged commit 244e3b7 into master Aug 24, 2023
@ozyx ozyx deleted the abort-limits branch August 24, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add abort functionality to Telemetry Collection requests and "getLimits"
5 participants