Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abort functionality to Telemetry Collection requests and "getLimits" #6871

Closed
jvigliotta opened this issue Aug 1, 2023 · 3 comments · Fixed by #6872
Closed

Add abort functionality to Telemetry Collection requests and "getLimits" #6871

jvigliotta opened this issue Aug 1, 2023 · 3 comments · Fixed by #6872

Comments

@jvigliotta
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Regular telemetry requests will abort on navigation. Telemetry Collection requests only abort when destroyed, which is dependent on the view that created the collection and the load on the UI at the time. We should also have a backup that will cancel on navigation for Telemetry Collection requests.

Requests for limits are asynchronous and should also support aborting on navigation as they are initiated from the Telemetry API and the groundwork is already there to support this.

Describe the solution you'd like
Abort'n

Describe alternatives you've considered
Not abort'n

@jvigliotta
Copy link
Contributor Author

Testing

  • throttle your network in the dev console network tab
  • go to a view that uses Telemetry Collections (Telemetry Table, LAD, etc) and a view that requests limits (Overlay Plot)
  • go to the view, nav away before requests have completed
  • observe requests for limits have been cancelled as well aa requests triggered from a Telemetry Collection view

@ozyx ozyx added this to the Target:3.0.1 milestone Aug 2, 2023
@akhenry
Copy link
Contributor

akhenry commented Aug 2, 2023

Please also verify that the errors reported in VIPEROMCT-386 are also resolved. If not, file a separate issue to fix.

@michaelrogers
Copy link
Contributor

michaelrogers commented Oct 3, 2023

This fix is verified during testathon 10/03/23. Telemetry collections and overlay plots stop trying to make fetch happen when navigating away.

Though I am seeing the AbortError Dave observed in VIPEROMCT-386.
Screenshot 2023-10-03 at 5 19 35 PM

@ozyx - should I file a separate issue for this?

@ozyx ozyx removed the unverified label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment