Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aborts] Abort Telemetry Collections requests on Navigation, Add abort functionality to getLimits #6872

Merged
merged 12 commits into from
Aug 24, 2023
Merged

[Aborts] Abort Telemetry Collections requests on Navigation, Add abort functionality to getLimits #6872

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0c633d6
debug
jvigliotta Jul 28, 2023
4eebe53
abort any pending requests on router "change:path" event, this should…
jvigliotta Jul 28, 2023
3658ec2
english
jvigliotta Jul 28, 2023
9a5c292
cant always be on
jvigliotta Jul 28, 2023
2065236
adding abort to limits requests
jvigliotta Jul 29, 2023
51b3ac5
finally-ing off the promise
jvigliotta Aug 1, 2023
feb2d47
need to just return the object not the property
jvigliotta Aug 1, 2023
92d89a5
sticking with the try/catch structure we use elsewhere
jvigliotta Aug 1, 2023
b8a4f94
Merge branch 'tc-nav-abort' into abort-limits
jvigliotta Aug 1, 2023
7e495fb
Merge branch 'master' into abort-limits
unlikelyzero Aug 18, 2023
7d5c42f
removing abort on nav, as views should be calling destroy
jvigliotta Aug 22, 2023
23937a1
Merge branch 'master' into abort-limits
shefalijoshi Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/api/telemetry/TelemetryAPI.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,6 +784,7 @@ export default class TelemetryAPI {
*/
getLimits(domainObject) {
const provider = this.#findLimitEvaluator(domainObject);

if (!provider || !provider.getLimits) {
return {
limits: function () {
Expand All @@ -792,7 +793,23 @@ export default class TelemetryAPI {
};
}

return provider.getLimits(domainObject);
const abortController = new AbortController();
const options = { signal: abortController.signal };
this.requestAbortControllers.add(abortController);

try {
return provider.getLimits(domainObject, options);
} catch (error) {
if (error.name !== 'AbortError') {
this.openmct.notifications.error(
'Error requesting telemetry data, see console for details'
);
}

throw new Error(error);
} finally {
this.requestAbortControllers.delete(abortController);
}
}
}

Expand Down