ImageryView 🖼️ + IndependentTimeConductor ⏰ #6791

scottbell · 2023-07-11T16:33:45Z

Describe your changes:

Adds the Independent Time Conductor to the ImageryView. Fixes TelemetryCollection to respond properly to time conductor changes.

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

Changes address original issue?
Tests included and/or updated with changes?
Command line build passes?
Has this been smoke tested?
Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

Changes appear to address issue?
Reviewer has tested changes by following the provided instructions?
Changes appear not to be breaking changes?
Appropriate automated tests included?
Code style and in-line documentation are appropriate?
Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

…uld-support-showing-more-images-than-the-conductor-bounds-1

…iew-should-support-showing-more-images-than-the-conductor-bounds-1

deploysentinel · 2023-07-11T16:38:06Z

Current Playwright Test Results Summary

✅ 55 Passing - ❌ 4 Failing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/15/2023 06:28:23am UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 2472351

Started: 07/15/2023 06:18:21am UTC

❌ Failures

📄 functional/plugins/plot/logPlot.e2e.spec.js • 1 Failure

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh Retry 2 • Retry 1 • Initial Attempt Error: Test timeout of 180000ms exceeded. `Test timeout of 180000ms exceeded.`	25% (38) 38 / 152 runs failed over last 7 days	3.29% (5) 5 / 152 runs flaked over last 7 days

📄 functional/planning/timelist.e2e.spec.js • 1 Failure

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds Retry 2 • Retry 1 • Initial Attempt Error: expect(received).toEqual(expected) // deep equality... `expect(received).toEqual(expected) // deep equality Expected: 5 Received: 0`	8.18% (13) 13 / 159 runs failed over last 7 days	0% (0) 0 / 159 runs flaked over last 7 days

📄 functional/notification.e2e.spec.js • 1 Failure

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Notification Overlay Closing notification list after notification banner disappeared does not cause it to open automatically Retry 1 • Initial Attempt Error: Test timeout of 60000ms exceeded. `Test timeout of 60000ms exceeded.`	21.35% (41) 41 / 192 runs failed over last 7 days	0% (0) 0 / 192 runs flaked over last 7 days

📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Failure

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Example Imagery Object Can use independent time conductor to change time Retry 1 • Initial Attempt Error: Test timeout of 60000ms exceeded. `Test timeout of 60000ms exceeded.`	100% (5) 5 / 5 runs failed over last 7 days	0% (0) 0 / 5 runs flaked over last 7 days

⚠️ Flakes

📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit Retry 1 • Initial Attempt	0% (0) 0 / 144 runs failed over last 7 days	2.78% (4) 4 / 144 runs flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit Retry 1 • Initial Attempt	0% (0) 0 / 144 runs failed over last 7 days	2.78% (4) 4 / 144 runs flaked over last 7 days

📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image Retry 1 • Initial Attempt	0.54% (1) 1 / 185 run failed over last 7 days	76.76% (142) 142 / 185 runs flaked over last 7 days

View Detailed Build Results

codecov · 2023-07-11T16:39:34Z

Codecov Report

Merging #6791 (2472351) into mode-dropdown (df6a3e4) will decrease coverage by 0.15%.
The diff coverage is 2.56%.

@@                Coverage Diff                @@
##           mode-dropdown    #6791      +/-   ##
=================================================
- Coverage          45.70%   45.56%   -0.15%     
=================================================
  Files                408      408              
  Lines              12493    12500       +7     
=================================================
- Hits                5710     5695      -15     
- Misses              6783     6805      +22

Flag	Coverage Δ		*Carryforward flag
e2e-full	`41.81% <ø> (-0.03%)`	⬇️	Carriedforward from df6a3e4
e2e-stable	`39.49% <2.56%> (-0.04%)`	⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
example/imagery/plugin.js	`28.81% <0.00%> (-1.02%)`	⬇️
src/api/telemetry/TelemetryAPI.js	`72.33% <0.00%> (-2.67%)`	⬇️
src/api/telemetry/TelemetryCollection.js	`60.00% <0.00%> (-6.86%)`	⬇️
src/plugins/imagery/mixins/imageryData.js	`4.59% <0.00%> (ø)`
src/utils/staleness.js	`66.66% <100.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df6a3e4...2472351. Read the comment docs.

…iew-should-support-showing-more-images-than-the-conductor-bounds-1

src/plugins/imagery/components/ImageryView.vue

src/ui/layout/BrowseBar.vue

jvigliotta

Couple questions and changes! Nice work!

akhenry · 2023-07-15T00:37:37Z

src/plugins/imagery/components/ImageryView.vue

      if (this.timeContext) {
-        hasClock = this.timeContext.clock();
+        return this.timeContext.isRealTime();


Independent time contexts and the global time context have an identical interface, so this code shouldn't care which one it's dealing with.

…iew-should-support-showing-more-images-than-the-conductor-bounds-1

scottbell added 12 commits July 7, 2023 10:05

add indepdendent time conductor to image view and add tests

0d04bed

undo old changes

de7ffab

fix tests and formatting

8c1d5fe

Merge remote-tracking branch 'origin/master' into 6434-image-view-sho…

15777af

…uld-support-showing-more-images-than-the-conductor-bounds-1

add debugging

bf43295

resolve conflicts

f8af695

get rid of deprecation warnings

1ef715b

sort works

ca57a00

change clocks

d0bbdc6

Merge remote-tracking branch 'origin/mode-dropdown' into 6434-image-v…

b5b837e

…iew-should-support-showing-more-images-than-the-conductor-bounds-1

imagery view works

4729dac

remove debug code

dabd840

scottbell linked an issue Jul 11, 2023 that may be closed by this pull request

Image view should support showing more images than the conductor bounds #6434

Closed

scottbell changed the title ~~ImageryView + IndependentTimeConductor ⏰~~ ImageryView 🖼️ + IndependentTimeConductor ⏰ Jul 11, 2023

linting

4676657

scottbell requested review from shefalijoshi and jvigliotta July 11, 2023 17:17

Merge remote-tracking branch 'origin/mode-dropdown' into 6434-image-v…

8bad2f1

…iew-should-support-showing-more-images-than-the-conductor-bounds-1

akhenry requested review from akhenry and removed request for shefalijoshi July 13, 2023 17:20

scottbell added 2 commits July 14, 2023 10:24

Merge remote-tracking branch 'origin/mode-dropdown' into 6434-image-v…

c3144c5

…iew-should-support-showing-more-images-than-the-conductor-bounds-1

fix conflicts

8d677d0

scottbell marked this pull request as ready for review July 14, 2023 18:53

jvigliotta changed the base branch from master to mode-dropdown July 14, 2023 19:12

jvigliotta reviewed Jul 14, 2023

View reviewed changes

src/plugins/imagery/components/ImageryView.vue Outdated Show resolved Hide resolved

jvigliotta reviewed Jul 14, 2023

View reviewed changes

src/plugins/imagery/components/ImageryView.vue Outdated Show resolved Hide resolved

jvigliotta reviewed Jul 14, 2023

View reviewed changes

src/plugins/imagery/components/ImageryView.vue Outdated Show resolved Hide resolved

jvigliotta reviewed Jul 14, 2023

View reviewed changes

src/ui/layout/BrowseBar.vue Show resolved Hide resolved

jvigliotta requested changes Jul 14, 2023

View reviewed changes

resolve PR comments

fac43f7

scottbell requested a review from jvigliotta July 14, 2023 20:15

akhenry reviewed Jul 15, 2023

View reviewed changes

akhenry approved these changes Jul 15, 2023

View reviewed changes

Merge remote-tracking branch 'origin/mode-dropdown' into 6434-image-v…

2472351

…iew-should-support-showing-more-images-than-the-conductor-bounds-1

jvigliotta merged commit 249f820 into mode-dropdown Jul 17, 2023

jvigliotta deleted the 6434-image-view-should-support-showing-more-images-than-the-conductor-bounds-1 branch July 17, 2023 21:53

ozyx added this to the Target:3.0.0 milestone Jul 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ImageryView 🖼️ + IndependentTimeConductor ⏰ #6791

ImageryView 🖼️ + IndependentTimeConductor ⏰ #6791

scottbell commented Jul 11, 2023 •

edited

Loading

deploysentinel bot commented Jul 11, 2023 •

edited

Loading

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

codecov bot commented Jul 11, 2023 •

edited

Loading

jvigliotta left a comment

akhenry Jul 15, 2023 •

edited

Loading

ImageryView 🖼️ + IndependentTimeConductor ⏰ #6791

ImageryView 🖼️ + IndependentTimeConductor ⏰ #6791

Conversation

scottbell commented Jul 11, 2023 • edited Loading

Describe your changes:

All Submissions:

Author Checklist

Reviewer Checklist

deploysentinel bot commented Jul 11, 2023 • edited Loading

Current Playwright Test Results Summary

❌ Failures

Test Case Results

Test Case Results

Test Case Results

Test Case Results

⚠️ Flakes

Top 1 Common Error Messages

Test Case Results

Test Case Results

codecov bot commented Jul 11, 2023 • edited Loading

Codecov Report

jvigliotta left a comment

Choose a reason for hiding this comment

akhenry Jul 15, 2023 • edited Loading

Choose a reason for hiding this comment

scottbell commented Jul 11, 2023 •

edited

Loading

deploysentinel bot commented Jul 11, 2023 •

edited

Loading

codecov bot commented Jul 11, 2023 •

edited

Loading

akhenry Jul 15, 2023 •

edited

Loading