Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image view should support showing more images than the conductor bounds #6434

Closed
scottbell opened this issue Mar 15, 2023 · 10 comments · Fixed by #6791
Closed

Image view should support showing more images than the conductor bounds #6434

scottbell opened this issue Mar 15, 2023 · 10 comments · Fixed by #6791
Assignees
Labels
type:enhancement type:feature Feature. Required intentional design
Milestone

Comments

@scottbell
Copy link
Contributor

scottbell commented Mar 15, 2023

Is your feature request related to a problem? Please describe.
Users would prefer if Imagery in the thumb strip persisted and was not removed by the Time Conductor bounds, while using a designated "now" context (local clock, remote clock). This supports the usage scenario of wanting to globally see plotted data for around 15 minutes, but imagery for much longer.

Describe the solution you'd like

  1. A toggle switch for Imagery views, per view and enabled by default, that makes that view ignore the TC real-time bounds. "Now" would still be defined by the TC.
    Discuss if Fixed Timespan mode would or would not pay attention to this setting.
  2. Independent Time Conductor is another possibility, but that UX is more cumbersome to deal with for this use case; option 1 above would be preferred.

Additional context
For images it's good enough to just enable the independent time conductor for now.

@unlikelyzero
Copy link
Contributor

This will potentially be very problematic if we're requesting hundreds of images of 5.5 MB, unbounded

@unlikelyzero unlikelyzero added this to the Target:2.2.1 milestone Mar 15, 2023
@scottbell
Copy link
Contributor Author

This will potentially be very problematic if we're requesting hundreds of images of 5.5 MB, unbounded

@unlikelyzero I think the idea here (at least at first) is to slap an independent time conductor on here instead. I know at one point we were linking at automatic thumbnailing/caching through a proxy (e.g., Apache), but not sure where that ended.

@unlikelyzero
Copy link
Contributor

@scottbell let me know when you have a WIP PR. I have a Driver displaylayout with 12 Images formatted for the MMOC Monitors. I want to show you how the independent time conductor would affect the screen real estate

@scottbell
Copy link
Contributor Author

scottbell commented Mar 22, 2023

@unlikelyzero the screen real estate isn't much, about 22 pixels in height:
Screenshot 2023-03-22 at 11 32 44 AM

@unlikelyzero
Copy link
Contributor

When you're ready, let me deploy it and we can look at it inside of a driver display

@ozyx
Copy link
Contributor

ozyx commented Mar 22, 2023

This will potentially be very problematic if we're requesting hundreds of images of 5.5 MB, unbounded

Worth noting that the Imagery View can support thumbnail size images in the image strip now.

@scottbell scottbell linked a pull request Mar 23, 2023 that will close this issue
15 tasks
@scottbell
Copy link
Contributor Author

To test:

  1. Bring up Example Imagery View
  2. Flip the button near the top of the view to turn on independent time
  3. Ensure Real Time and Fixed Time both work, and that the images generated match what the time conductor is asking for
Screen.Recording.2023-03-23.at.9.03.42.AM.mov

@scottbell
Copy link
Contributor Author

I "think" this is still waiting on some independent time conductor UI changes, is that correct @jvigliotta / @akhenry?

@scottbell scottbell linked a pull request Jul 11, 2023 that will close this issue
15 tasks
@unlikelyzero unlikelyzero added the type:feature Feature. Required intentional design label Jul 18, 2023
@unlikelyzero unlikelyzero added this to the Target:3.0.0 milestone Jul 18, 2023
@ozyx ozyx closed this as completed Jul 19, 2023
@rukmini-bose
Copy link
Contributor

Verified Testathon 6/24/2023. All different ITC time settings seem to generate the write type of images.

@ozyx
Copy link
Contributor

ozyx commented Jul 24, 2023

Verified Testathon 7/24/23. Setting the ITC to greater bounds than the global conductor displays the correct number of images in the Imagery view

@ozyx ozyx removed the unverified label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement type:feature Feature. Required intentional design
Projects
None yet
6 participants