[Time] Conductors and API Enhancements #6768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved IndependentTimeConductor.vue into BrowseBar.vue. - Styling for read-only conductor views. - VERY WIP!
- Significant CSS and markup work. - Refinements to `c-icon-button` classes, including new `--compact` definition. - Styling for independent and main conductor components. - Code cleanups. - STILL WIP!
- Added CSS class `is-expanded` to main view TC component.
- Markup and script moved into new timePopup* components. - Significant work on styling. - Theme constants augmented, better naming.
- Styling for new mini toggle slider switch.
- Fixed inputs popup layout with style and layout. - More `$colorTime*` theme constants defined and applied. - Better CSS organization.
- Stubbed buttons into popups. - More `$colorTime*` theme constants defined and applied. - Still quite WIP!
- Layout, display behavior. - Hide functional buttons to be moved. - Remove unneeded markup. - Input widths for fixed popup date and time. - Add new `c-not-button` class. - Add new `u-flex-spreader` class. - Code cleanups.
- Fix SCSS error.
- Layout, display behavior for Time Conductor in layout frames. - Code cleanups.
- Convert Time Conductor symbol to use SVG instead of font glyph
- Styling for Time Conductor in layout frames.
…el work as expected
…or history for new api methods
…t on the fly, this way we are prepping for vue 3 and we can use v-if to destroy it
…ogramatic to v-ifs, mostly focused on conductor at the moment, independent next
shefalijoshi
requested changes
Jul 15, 2023
| @@ -46,16 +46,17 @@ export default { | |||
| }; | |||
| }, | |||
| mounted() { | |||
| this.unlisten = ticker.listen(this.tick); | |||
| this.tick = raf(this.tick); | |||
There was a problem hiding this comment.
In Remote-Clock mode the indicator updates the time very slowly - once every few seconds.
Is this expected?
| this.openmct.time.bounds(timeParameters.bounds); | ||
| const timeSystem = this.openmct.time.getTimeSystem(); | ||
|
|
||
| if (timeParameters.mode === FIXED_MODE_KEY) { |
There was a problem hiding this comment.
We have no way of setting the clock anymore. Perhaps create a new issue for that?
* Emit bounds events only when it's appropriate * Optimize timeConductor plugin initialization * add missing code to independent time conductor and timecontext * Don't set fixed time bounds if no clock * Check for bounds before emitting bounds on setMode * modifying how imagery tests select realtime mode * Update the API so that the setClock API no longer accepts the clockOffset. Update the setMode API to accept offsets or fixed time bounds * Update usages of setClock and setMode to pass the right bounds/clockOffsets * Fix code based on test failures * Default time value to openmct.time.now() instead of null * Fix TimeAPI and set the clock and mode in test setup --------- Co-authored-by: Jamie V <[email protected]> Co-authored-by: Andrew Henry <[email protected]>
* add indepdendent time conductor to image view and add tests * undo old changes * fix tests and formatting * add debugging * get rid of deprecation warnings * sort works * change clocks * imagery view works * remove debug code * linting * resolve PR comments
shefalijoshi
approved these changes
Jul 18, 2023
* modify openmct to set a default "local" clock if no other clock is set on load, make it so clocks are not started only when they get a listener and not stopped with they have no listeners, start/stop clocks in "setClock" method * adding start/stop to independent time context as well * had to modify a few things to get clock indicator test to work * cleanup * more cleanup * reverting * revert * revert
This was referenced Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4975
Closes #5773
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist