Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mode dropdown clock bounds fix #6804

Merged
merged 15 commits into from
Jul 17, 2023
Merged

Conversation

shefalijoshi
Copy link
Contributor

Cleans up some loose ends for Time API.
Also optimizes the timeConductor plugin initialization code.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Jul 15, 2023

Current Playwright Test Results Summary

✅ 76 Passing - ❌ 3 Failing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/17/2023 09:41:46pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 5dd0ad9

Started: 07/17/2023 09:31:39pm UTC

❌ Failures

📄   functional/plugins/plot/autoscale.e2e.spec.js • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Autoscale User can set autoscale with a valid range @snapshot
Retry 2Retry 1Initial Attempt
Error: Test timeout of 180000ms exceeded.
Test timeout of 180000ms exceeded.
43.22% (86) 86 / 199 runs
failed over last 7 days
5.03% (10) 10 / 199 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 2Retry 1Initial Attempt
Error: expect(received).toEqual(expected) // deep equality...
expect(received).toEqual(expected) // deep equality

Expected: 5
Received: 0
10.99% (20) 20 / 182 runs
failed over last 7 days
0% (0) 0 / 182 runs
flaked over last 7 days

📄   functional/notification.e2e.spec.js • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Notification Overlay Closing notification list after notification banner disappeared does not cause it to open automatically
Retry 1Initial Attempt
Error: Test timeout of 60000ms exceeded.
Test timeout of 60000ms exceeded.
21.76% (47) 47 / 216 runs
failed over last 7 days
0% (0) 0 / 216 runs
flaked over last 7 days

⚠️ Flakes

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1Initial Attempt
0.49% (1) 1 / 206 run
failed over last 7 days
77.67% (160) 160 / 206 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #6804 (5dd0ad9) into mode-dropdown (df6a3e4) will increase coverage by 2.89%.
The diff coverage is 55.81%.

@@                Coverage Diff                @@
##           mode-dropdown    #6804      +/-   ##
=================================================
+ Coverage          45.70%   48.60%   +2.89%     
=================================================
  Files                408      408              
  Lines              12493    12508      +15     
=================================================
+ Hits                5710     6079     +369     
+ Misses              6783     6429     -354     
Flag Coverage Δ *Carryforward flag
e2e-full 41.82% <ø> (-0.02%) ⬇️ Carriedforward from 97cb5ce
e2e-stable 44.48% <55.81%> (+4.94%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
src/api/time/IndependentTimeContext.js 29.93% <0.00%> (-1.06%) ⬇️
src/api/time/TimeAPI.js 69.69% <0.00%> (+10.87%) ⬆️
...ettingsSynchronizer/URLTimeSettingsSynchronizer.js 89.89% <71.42%> (+5.05%) ⬆️
src/plugins/timeConductor/plugin.js 78.43% <76.92%> (+5.09%) ⬆️
src/api/time/TimeContext.js 66.45% <90.00%> (-1.49%) ⬇️

... and 47 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df6a3e4...5dd0ad9. Read the comment docs.

@jvigliotta jvigliotta merged commit 7fa554b into mode-dropdown Jul 17, 2023
@jvigliotta jvigliotta deleted the mode-dropdown-clock-bounds-fix branch July 17, 2023 21:45
@ozyx ozyx added this to the Target:3.0.0 milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants