-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define navigation memory leak tests for some view types. #6718
Conversation
Current Playwright Test Results Summary✅ 122 Passing - ❌ 1 Failing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/07/2023 05:12:27pm UTC) ❌ Failures📄 framework/baseFixtures.e2e.spec.js • 1 FailureTest Case Results
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1 • Initial Attempt |
29.63% (8)8 / 27 runsfailed over last 7 days |
55.56% (15)15 / 27 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6718 +/- ##
==========================================
- Coverage 53.87% 53.34% -0.54%
==========================================
Files 624 624
Lines 24848 24848
Branches 2493 2493
==========================================
- Hits 13386 13254 -132
- Misses 10794 10924 +130
- Partials 668 670 +2
*This pull request uses carry forward flags. Click here to find out more. see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@akhenry Please close this PR - seems like an incomplete one. |
Superseded by #7057 |
Closes #4406
Describe your changes:
Defines a basic set of Playwright tests to detect a particular class of memory leaks that are easy to accidentally introduce. The memory leak that it detects occur on navigation away from a view, where the view's resources are not garbage collected and continue to use resources indefinitely.
This type of memory leak is almost always caused by a failure to clean up event listeners on destroy.
TODO:
All Submissions:
Author Checklist
Reviewer Checklist