Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically Check Additional Views for Memory Leaks on navigation #6734

Closed
10 tasks done
akhenry opened this issue Jun 14, 2023 · 5 comments · Fixed by #7300
Closed
10 tasks done

Automatically Check Additional Views for Memory Leaks on navigation #6734

akhenry opened this issue Jun 14, 2023 · 5 comments · Fixed by #7300
Assignees
Labels
performance impacts or improves performance type:maintenance tests, chores, or project maintenance verified Tested or intentionally closed
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented Jun 14, 2023

Follow on from #4406

#6718 introduces the ability to test views for memory leaks on navigation, as well as memory leak tests for a number of screens. To limit the scope of that PR we have split the screens between two issues. This issue contains the second and final batch of screens that need memory leak tests defined in the open repo.

Note that tests are defined for some but not all of these, but are disabled due to finding memory leaks. The memory leaks will need to be fixed before merging this PR.

  • Gauges
  • Plan View
  • Time List View
  • Scatter Plot
  • Graph
  • Gantt Chart
  • Clocks
  • Timers
  • Web Page
  • Complex Display Layouts
@akhenry akhenry added the type:maintenance tests, chores, or project maintenance label Jun 14, 2023
@unlikelyzero unlikelyzero added the performance impacts or improves performance label Aug 4, 2023
@akhenry
Copy link
Contributor Author

akhenry commented Oct 10, 2023

@michaelrogers michaelrogers self-assigned this Oct 31, 2023
@akhenry
Copy link
Contributor Author

akhenry commented Dec 10, 2023

See https://github.com/nasa/openmct/pull/7224/files which may address some of these issues.

@scottbell scottbell self-assigned this Dec 11, 2023
@scottbell
Copy link
Contributor

@michaelrogers I've added objects for testing these objects in the associated branch to this issue:
Screenshot 2023-12-14 at 10 02 37 AM

@scottbell
Copy link
Contributor

@michaelrogers I've got the tests in place, and there are three tests failing currently:

Running 25 tests using 1 worker

  ✓  1 [chrome-memory] › memory/navigation.memory.perf.spec.js:63:3 › Navigation memory leak is not detected in › guage (5.5s)
  ✓  2 [chrome-memory] › memory/navigation.memory.perf.spec.js:72:3 › Navigation memory leak is not detected in › plan (4.6s)
  ✓  3 [chrome-memory] › memory/navigation.memory.perf.spec.js:81:3 › Navigation memory leak is not detected in › time list (30.3s)
  ✘  4 [chrome-memory] › memory/navigation.memory.perf.spec.js:90:3 › Navigation memory leak is not detected in › scatter (60.0s)
  ✘  5 [chrome-memory] › memory/navigation.memory.perf.spec.js:99:3 › Navigation memory leak is not detected in › graph (60.0s)
  ✓  6 [chrome-memory] › memory/navigation.memory.perf.spec.js:108:3 › Navigation memory leak is not detected in › gantt chart (5.3s)
  ✓  7 [chrome-memory] › memory/navigation.memory.perf.spec.js:117:3 › Navigation memory leak is not detected in › clock (4.6s)
  ✓  8 [chrome-memory] › memory/navigation.memory.perf.spec.js:126:3 › Navigation memory leak is not detected in › timer (30.3s)
  ✓  9 [chrome-memory] › memory/navigation.memory.perf.spec.js:135:3 › Navigation memory leak is not detected in › web page (nasa.gov) (4.6s)
  ✘  10 [chrome-memory] › memory/navigation.memory.perf.spec.js:144:3 › Navigation memory leak is not detected in › Complex Display Layout (60.0s)
  ✓  11 [chrome-memory] › memory/navigation.memory.perf.spec.js:153:3 › Navigation memory leak is not detected in › plot view (4.9s)
  ✓  12 [chrome-memory] › memory/navigation.memory.perf.spec.js:161:3 › Navigation memory leak is not detected in › stacked plot view (4.6s)
  ✓  13 [chrome-memory] › memory/navigation.memory.perf.spec.js:169:3 › Navigation memory leak is not detected in › LAD table view (4.6s)
  ✓  14 [chrome-memory] › memory/navigation.memory.perf.spec.js:177:3 › Navigation memory leak is not detected in › LAD table set (4.5s)
  ✓  15 [chrome-memory] › memory/navigation.memory.perf.spec.js:186:3 › Navigation memory leak is not detected in › telemetry table view (4.7s)
  ✓  16 [chrome-memory] › memory/navigation.memory.perf.spec.js:200:3 › Navigation memory leak is not detected in › notebook view (4.7s)
  ✓  17 [chrome-memory] › memory/navigation.memory.perf.spec.js:213:3 › Navigation memory leak is not detected in › display layout of a single SWG alphanumeric (4.7s)
  ✓  18 [chrome-memory] › memory/navigation.memory.perf.spec.js:226:3 › Navigation memory leak is not detected in › display layout of a single SWG plot (30.3s)
  ✓  19 [chrome-memory] › memory/navigation.memory.perf.spec.js:240:3 › Navigation memory leak is not detected in › example imagery view (30.3s)
  ✓  20 [chrome-memory] › memory/navigation.memory.perf.spec.js:253:3 › Navigation memory leak is not detected in › display layout of example imagery views (30.3s)
  ✓  21 [chrome-memory] › memory/navigation.memory.perf.spec.js:266:3 › Navigation memory leak is not detected in › display layout with plots of swgs, alphanumerics, and condition sets,  (5.7s)
  ✓  22 [chrome-memory] › memory/navigation.memory.perf.spec.js:281:3 › Navigation memory leak is not detected in › flexible layout with plots of swgs (5.1s)
  ✓  23 [chrome-memory] › memory/navigation.memory.perf.spec.js:294:3 › Navigation memory leak is not detected in › flexible layout of example imagery views (30.3s)
  ✓  24 [chrome-memory] › memory/navigation.memory.perf.spec.js:307:3 › Navigation memory leak is not detected in › tabbed view of display layouts and time strips (7.4s)
  ✓  25 [chrome-memory] › memory/navigation.memory.perf.spec.js:320:3 › Navigation memory leak is not detected in › time strip view of telemetry (4.9s)

so scatter plots, bar graphs, and complex display layouts.

@scottbell
Copy link
Contributor

@michaelrogers fixed the memory leaks. I'm going to make a PR

@scottbell scottbell linked a pull request Dec 14, 2023 that will close this issue
15 tasks
@unlikelyzero unlikelyzero added this to the Target:4.0.0 milestone Feb 8, 2024
@unlikelyzero unlikelyzero added the verified Tested or intentionally closed label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance impacts or improves performance type:maintenance tests, chores, or project maintenance verified Tested or intentionally closed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants