Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Check views for memory leak on navigation #4406

Closed
12 tasks done
akhenry opened this issue Oct 29, 2021 · 1 comment · Fixed by #7057
Closed
12 tasks done

[Performance] Check views for memory leak on navigation #4406

akhenry opened this issue Oct 29, 2021 · 1 comment · Fixed by #7057
Assignees
Labels
performance impacts or improves performance type:maintenance tests, chores, or project maintenance
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented Oct 29, 2021

There is a class of memory leak that occurs where references to view objects are retained even after the view has been destroyed. View destruction occurs on navigation.

The usual reason for this is a failure to clean up event handlers.

This can cause performance degradation of the application over time as memory builds up. This is a particular issue with views that hold onto historical telemetry.

A draft PR exists that provides a framework for implementing this kind of test. It should be configured to run on every PR to catch memory leaks as soon as they are introduced. The draft PR defines tests for the following object views:

  • Overlay Plots
  • Stacked Plots
  • Tables
  • LAD Tables
  • LAD Table Sets
  • Imagery View (Except for CompassRose)
  • Simple Display Layouts
  • Simple Flexible Layouts
  • Notebooks
  • Tabs View
  • Condition Widget
  • Timeline View

Filed followup for remaining screens - #6734
Also see: #4209

@unlikelyzero unlikelyzero added type:maintenance tests, chores, or project maintenance performance impacts or improves performance labels Oct 30, 2021
@unlikelyzero unlikelyzero changed the title Check views for memory leak on navigation [Performance] Check views for memory leak on navigation Oct 30, 2021
@akhenry akhenry added this to the Target:2.2.5 milestone Jun 14, 2023
@shefalijoshi shefalijoshi self-assigned this Sep 14, 2023
@shefalijoshi
Copy link
Contributor

shefalijoshi commented Sep 15, 2023

Testing Instructions:

  • Retest Display Layout actions
  • Retest Drawing tools for display layouts - Box, Line, Ellipse, Text, Image
  • Retest resizing display layouts
  • Retest Flexible Layout actions - Rukmini
  • Retest Plot limit lines - John
  • Plot annotations (including searching for annotations and clicking on search results) - Jesse
  • Data Pivoting (getting here should touch a lot of other components) - Dave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance impacts or improves performance type:maintenance tests, chores, or project maintenance
Projects
None yet
4 participants