Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove can edit from hyperlink #4076

Merged
merged 1 commit into from
Aug 3, 2021
Merged

remove can edit from hyperlink #4076

merged 1 commit into from
Aug 3, 2021

Conversation

kobe1104
Copy link
Contributor

@kobe1104 kobe1104 commented Aug 3, 2021

Issue: #4056

The change from this PR will remove the edit mode from hyperlink to meet the expected behavior.
For tests please refer to #4062

All Submissions:

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

@davetsay davetsay merged commit 1b034f6 into 1.7.6 Aug 3, 2021
@davetsay davetsay deleted the remove-canedit-hyperlink branch August 3, 2021 23:01
kobe1104 added a commit that referenced this pull request Aug 10, 2021
* remove can edit from hyperlink (#4076)

* Add check for stop observing before calling it (#4080)

* Set the yKey value on the series when it's changed (#4083)

* [Imagery] Click on image to get a large view #3582 (#4085)

fixed issue where large imagery view opens only once.

Co-authored-by: Henry Hsu <[email protected]>
Co-authored-by: Nikhil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants