Check for observing changes before asking it to stop #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobe1104
approved these changes
Aug 4, 2021
There was a problem hiding this comment.
Hi @shefalijoshi I've verified the change. I didn't see any issue.
jvigliotta
approved these changes
Aug 4, 2021
There was a problem hiding this comment.
LGTM!
Reviewer Checklist
| Check | Passed |
|---|---|
| Changes appear to address issue?? | Y |
| Appropriate unit tests included? | Not warranted |
| Code style and in-line documentation are appropriate? | Y |
| Commit messages meet standards? | Y |
| Has associated issue been labelled unverified? (if PR closes issue) | Y |
kobe1104
added a commit
that referenced
this pull request
Aug 10, 2021
* remove can edit from hyperlink (#4076) * Add check for stop observing before calling it (#4080) * Set the yKey value on the series when it's changed (#4083) * [Imagery] Click on image to get a large view #3582 (#4085) fixed issue where large imagery view opens only once. Co-authored-by: Henry Hsu <[email protected]> Co-authored-by: Nikhil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4074
All Submissions:
Author Checklist