Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement Hyperlink plugin with Vue #4056

Closed
kobe1104 opened this issue Jul 26, 2021 · 10 comments
Closed

Re-implement Hyperlink plugin with Vue #4056

kobe1104 opened this issue Jul 26, 2021 · 10 comments
Assignees

Comments

@kobe1104
Copy link
Contributor

kobe1104 commented Jul 26, 2021

The existing HyperLink plugin and controller are currently implemented as a legacy bundle and written in Angular.js . They should be re-implemented as a plugin under /src/plugins using our current API, with the UI migrated to Vue.

Any legacy code associated with the legacy HyperLink plugin should be removed and replaced by the new one.

@charlesh88
Copy link
Contributor

Testing Notes

These notes are focused on regression testing for changes that occurred to main view, sub-object and preview containers:

  1. Create one of every type of view that we have.
  2. Navigate to each view object and ensure it looks as expected.
  3. Add each newly created object into a Display or Flexible Layout.; ideally, some testers do one and some do the other. Save the layout and verify each framed element looks as expected.
    Screen Shot 2021-07-28 at 2 58 02 PM
  4. From the layout, use each frame's View Large function to see that object in the overlay "Preview" view. Verify again that all views look as expected.

@kobe1104
Copy link
Contributor Author

kobe1104 commented Aug 3, 2021

Testing instructions

  1. On openmct, create a hyperlink by clicking on the '+Create' dropdown menu on top left.
  2. On the create hyperlink window, add URL and text to display. Pick either link or button for display format and open in new tab or this tab.
  3. Verify that the hyperlink has the expected style (either link or button) and it opens the tab in the expected way.

@nikhilmandlik
Copy link
Contributor

unable to create new Hyperlink object

@unlikelyzero unlikelyzero reopened this Aug 3, 2021
@nikhilmandlik nikhilmandlik linked a pull request Aug 3, 2021 that will close this issue
7 tasks
@davetsay
Copy link
Contributor

davetsay commented Aug 3, 2021

@kobe1104 , I think hyperlink should not be an editable object. Basically, remove the canEdit block in the object view provider.

@shefalijoshi
Copy link
Contributor

Marking this as closed as this was merged into 1.7.6.

@davetsay
Copy link
Contributor

davetsay commented Aug 5, 2021

verified

@kobe1104
Copy link
Contributor Author

kobe1104 commented Aug 5, 2021

Verified fixed. Testathon 8/5/2021

@shefalijoshi
Copy link
Contributor

Verified fixed

@nikhilmandlik
Copy link
Contributor

found adding www.nasa.gov/ does not redirect to https://www.nasa.gov/
Screen Shot 2021-08-05 at 4 21 41 PM

@unlikelyzero
Copy link
Contributor

@nikhilmandlik to file a bug on the existing behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants