Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow identity overrides to be created for non-existent identities #5081

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

matthewelwell
Copy link
Contributor

Changes

Updates the PUT request to create a new identity override for an edge identity to create the identity if it doesn't already exist.

How did you test this code?

Added an integration test.

@matthewelwell matthewelwell requested a review from a team as a code owner February 6, 2025 14:59
@matthewelwell matthewelwell requested review from zachaysan and removed request for a team February 6, 2025 14:59
Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Feb 6, 2025 2:59pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Feb 6, 2025 2:59pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Feb 6, 2025 2:59pm

@matthewelwell matthewelwell requested review from gagantrivedi and removed request for zachaysan February 6, 2025 14:59
@github-actions github-actions bot added api Issue related to the REST API fix labels Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5081 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5081 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5081 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5081 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5081 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api-test:pr-5081 Finished ✅ Skipped

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Uffizzi Preview deployment-60694 was deleted.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.43%. Comparing base (895e5b8) to head (85f1937).
Report is 59 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5081   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files        1214     1214           
  Lines       42277    42296   +19     
=======================================
+ Hits        41193    41213   +20     
+ Misses       1084     1083    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 merged commit c61839e into main Feb 25, 2025
37 checks passed
@khvn26 khvn26 deleted the fix/allow-put-identity-override-to-create-identity branch February 25, 2025 10:09
khvn26 added a commit that referenced this pull request Feb 25, 2025
@khvn26 khvn26 mentioned this pull request Feb 25, 2025
4 tasks
khvn26 added a commit that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants