Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Linting errors for #5081 #5160

Merged
merged 1 commit into from
Feb 25, 2025
Merged

chore: Linting errors for #5081 #5160

merged 1 commit into from
Feb 25, 2025

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Feb 25, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This fixes the CI failing since we merged #5081 without rebasing on fresh main.

How did you test this code?

In CI.

@khvn26 khvn26 requested a review from a team as a code owner February 25, 2025 10:32
@khvn26 khvn26 requested review from matthewelwell and removed request for a team February 25, 2025 10:32
Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Feb 25, 2025 10:32am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Feb 25, 2025 10:32am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Feb 25, 2025 10:32am

@github-actions github-actions bot added api Issue related to the REST API chore labels Feb 25, 2025
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5160 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5160 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5160 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5160 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5160 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5160 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Feb 25, 2025

Uffizzi Preview deployment-61301 was deleted.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.47%. Comparing base (27a69a9) to head (d47fb99).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5160   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files        1224     1224           
  Lines       42567    42590   +23     
=======================================
+ Hits        41491    41515   +24     
+ Misses       1076     1075    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 merged commit 9a58249 into main Feb 25, 2025
37 checks passed
@khvn26 khvn26 deleted the fix/put-identities-linting branch February 25, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants