Skip to content

Commit d47fb99

Browse files
committed
fix: Linting errors for #5081
1 parent c61839e commit d47fb99

File tree

2 files changed

+18
-11
lines changed

2 files changed

+18
-11
lines changed

api/edge_api/identities/views.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from django.shortcuts import get_object_or_404
1111
from django.utils.decorators import method_decorator
1212
from drf_yasg.utils import swagger_auto_schema # type: ignore[import-untyped]
13-
from flag_engine.identities.models import IdentityFeaturesList
13+
from flag_engine.identities.models import IdentityFeaturesList, IdentityModel
1414
from flag_engine.identities.traits.models import TraitModel
1515
from pyngo import drf_error_details
1616
from rest_framework import status, viewsets

api/tests/integration/edge_api/identities/test_edge_identity_featurestates_viewset.py

+17-10
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
MultivariateFeatureStateValueModel,
1515
)
1616
from mypy_boto3_dynamodb.service_resource import Table
17+
from mypy_boto3_dynamodb.type_defs import TableAttributeValueTypeDef
1718
from pytest_lazyfixture import lazy_fixture # type: ignore[import-untyped]
1819
from pytest_mock import MockerFixture
1920
from rest_framework import status
@@ -899,12 +900,12 @@ def test_edge_identities_with_identifier_update_featurestate( # type: ignore[no
899900
def test_put_identity_override_creates_identity_if_not_found(
900901
dynamodb_wrapper_v2: DynamoEnvironmentV2Wrapper,
901902
admin_client: APIClient,
902-
environment: Environment,
903+
environment: int,
903904
environment_api_key: str,
904-
feature: Feature,
905+
feature: int,
905906
webhook_mock: mock.MagicMock,
906907
flagsmith_identities_table: Table,
907-
):
908+
) -> None:
908909
# Given
909910
identifier = "some_new_identity"
910911
url = reverse(
@@ -939,13 +940,19 @@ def test_put_identity_override_creates_identity_if_not_found(
939940
assert identity["identifier"] == identifier
940941

941942
# and that they have the relevant override
942-
assert len(identity["identity_features"]) == 1
943-
assert identity["identity_features"][0]["feature"]["id"] == feature
944-
assert identity["identity_features"][0]["enabled"] == expected_fs_enabled
945-
assert (
946-
identity["identity_features"][0]["feature_state_value"]
947-
== expected_feature_state_value
948-
)
943+
identity_features_data = typing.cast(
944+
list[typing.Mapping[str, TableAttributeValueTypeDef]],
945+
identity["identity_features"],
946+
)
947+
feature_state_data = identity_features_data[0]
948+
feature_data = typing.cast(
949+
typing.Mapping[str, TableAttributeValueTypeDef],
950+
feature_state_data["feature"],
951+
)
952+
assert len(identity_features_data) == 1
953+
assert feature_data["id"] == feature
954+
assert feature_state_data["enabled"] == expected_fs_enabled
955+
assert feature_state_data["feature_state_value"] == expected_feature_state_value
949956

950957

951958
@pytest.mark.parametrize(

0 commit comments

Comments
 (0)