d2renderer: #384 The arrowhead crow feet variants

[martinjirku]

Introduce new styles for arrowheads #384:

• crows-foot-many-required
• crows-foot-many-optional
• crows-foot-one-required
• crows-foot-one-optional

Open questions

I do not like crows-foot-* repeated 4 times, but it seems the simplest way to implement this, though d2 DSL for crows-foot is not the best DX.

Screenshots

This SVG:

is generated by this d2:

a <-> b: crows-foot-many-optional {
  source-arrowhead: {
    shape: crows-foot-many-optional
  }
  target-arrowhead: {
    shape: crows-foot-many-optional
  }
}

c <--> d: crows-foot-many-required {
  source-arrowhead: {
    shape: crows-foot-many-required
  }
  target-arrowhead: {
    shape: crows-foot-many-required
  }
}

e <--> f: crows-foot-one-required {
  source-arrowhead: {
    shape: crows-foot-one-required
  }
  target-arrowhead: {
    shape: crows-foot-one-required
  }
}

g <--> h: crows-foot-one-optional {
  source-arrowhead: {
    shape: crows-foot-one-optional
  }
  target-arrowhead: {
    shape: crows-foot-one-optional
  }
}

[alixander]

nice! these look great!

can you an e2e test to https://github.com/terrastruct/d2/blob/master/e2etests/stable_test.go?

i wonder if we can just remove the "crows-foot" to these names. and also the omission of "required" to signify optional.

many
many-required
one
one-required

any thoughts? i need to do some research to see if this is ambiguous, like if there's other symbols that people would expect with these keywords.

[alixander]

or maybe cf for shorthand? cf-one

[martinjirku]

cf-one | cf-many | cf-many-required | cf-one-required is definitely less to write. I am always afraid of abbreviations, but if it will be well documented, then it could be OK.

[alixander]

let's go with that then

[alixander]

@martinjirku could you sign your commits please? we have this requirement turned on in our org: #557 (comment) .

i'll make sure to document this (#580)

[alixander]

can you add a line to changelog? (https://github.com/terrastruct/d2/blob/master/ci/release/changelogs/next.md)

you can follow the format of previous changelogs: https://github.com/terrastruct/d2/blob/master/ci/release/changelogs/v0.1.4.md?plain=1

[martinjirku]

Finally, I've successfully signed my previous commits. Can you re-check?

[alixander]

g <--> h: {
  source-arrowhead: {
    shape: cf-one
  }
  target-arrowhead: {
    shape: cf-one
  }
}
h -> e -> a: {
  target-arrowhead: {
    shape:cf-many
  }
}
g -> e -> a: {
  target-arrowhead: {
    shape:cf-many-required
  }
}

1. The cf-many looks slightly off (black circle).
2. Also when the arrows approach at an angle, the crows feet don't match up to the border (red).

(1) should be fixed here, but i'm not sure what to do about (2). To extend these at an angle would also look weird. I'd say it's acceptable for now.

[alixander]

hmm actually i just noticed it's also off for other shapes too. this might be tricky to solve, you'd have to basically curve the crows foot too. i'll just put an issue to track. this PR doesn't need to address that

#581

[martinjirku]

1. The cf-many looks slightly off (black circle).
2. Also when the arrows approach at an angle, the crows feet don't match up to the border (red).

(1) should be fixed here, but i'm not sure what to do about (2). To extend these at an angle would also look weird. I'd say it's acceptable for now.

Is this acceptable as solution for (1)?

[alixander]

nice, yeah that's a good solution for now

[alixander]

awesome! is this ready to merge?

[martinjirku]

awesome! is this ready to merge?

Yes, ready to go 🚀