Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Crows Feet to Arrowhead options #384

Closed
Rjvs opened this issue Dec 6, 2022 · 7 comments
Closed

Add Crows Feet to Arrowhead options #384

Rjvs opened this issue Dec 6, 2022 · 7 comments
Labels
good first issue Good for newcomers render

Comments

@Rjvs
Copy link

Rjvs commented Dec 6, 2022

Hi, although documentation claims D2 is useful for ERDs, it would be useful to have more options for the arrowheads, such as crows feet.

@alixander alixander transferred this issue from terrastruct/d2-docs Dec 6, 2022
@cyborg-ts cyborg-ts added this to D2 Dec 6, 2022
@alixander alixander added good first issue Good for newcomers render labels Dec 8, 2022
@alixander
Copy link
Collaborator

not opposed to the additional optionality, but we also have arrowhead labels which kind of do the same thing. (https://d2lang.com/tour/connections#arrowheads). i guess i can see it in more formal settings (e.g. academic, database docs, etc)

@suhr
Copy link

suhr commented Dec 21, 2022

Crow's foot is a more compact and visual notation than labels.

PS: tastefully rendered crow's feet should be small, close to diamonds arrowheads in size.

alixander added a commit that referenced this issue Jan 1, 2023
d2renderer: #384 The arrowhead crow feet variants
@alixander
Copy link
Collaborator

closed by #578

@suhr you had an opinion on rendering, how's it look to you?

@github-project-automation github-project-automation bot moved this to Done in D2 Jan 3, 2023
@suhr
Copy link

suhr commented Jan 3, 2023

Proportions are rather unusual. Compare with this images:

entity-relationship-diagram-1536x781
php7wjEYw

The first picture is from a database design tool: https://www.datensen.com/blog/er-diagram/crows-foot-notation-in-erd/

@suhr
Copy link

suhr commented Jan 3, 2023

There's an another example: schema

@martinjirku
Copy link
Contributor

I was trying to replicate it from the blog mentioned in the original post.
If there is a need, it can be definitely improved.

@alixander
Copy link
Collaborator

yeah i'm interested to see what it looks like in practice.

i don't think the existing implementations out there are the gold standard by any means:

Screen Shot 2023-01-04 at 11 27 40 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers render
Projects
Status: Done
Development

No branches or pull requests

4 participants