Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Add percentage to flat and cumulative columns in table #3881

Closed
wants to merge 2 commits into from

Conversation

brancz
Copy link
Member

@brancz brancz commented Sep 26, 2023

This is a start of #3880, but we should separate it out to separate columns instead as the line breaks are not very good this way.

@metalmatze had some WIP work that allowed dynamically adding columns, I think that would be the right thing to do here.

Screenshot_2023-09-26_at_14 02 32

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Sep 26, 2023

✅ Meticulous spotted zero visual differences across 170 screens tested: view results.

Last updated for commit 063fc78. This comment will update as new commits are pushed.

@metalmatze
Copy link
Member

It would be great if we can merge #3780 first.

@brancz
Copy link
Member Author

brancz commented Sep 26, 2023

Agreed, like I said in the description I’d want this to use the column selector anyway.

@monicawoj
Copy link
Contributor

As the work was rather related, I've gone ahead and added these percentage columns directly in #3780 - please take a look there whenever you get a chance.

@brancz
Copy link
Member Author

brancz commented Oct 18, 2023

Superseded by #3780

@brancz brancz closed this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants