ui/profile/table: Add visibility dropdown for columns #3780
Conversation
metalmatze
commented
Sep 7, 2023
•
metalmatze
commented
- ui/profile/Table: Add dropdown to change column visibility
- ui/component/Table: Make table header sticky
Also, some additional performance improvements by moving getting the column references before the hot paths.
This should be better with long tables and sorting. Users don't have to scroll back to the top to sort.
|
Did you have a chance to take a look at it, @manojVivek? |
Didn't check it yet after the initial look. I'll take a look today and maybe ignore type check for that line if I couldn't resolve it. |
|
Oh, I just noticed @monicawoj is going to look into this, so I'll defer it to her. Fresh eyes might help. |
Apologies for the delay here @metalmatze (I was blocked for the past few days because of CORS errors, so was not able to check this locally). I'm just working on some linter/ts fixes and should be ready to merge soon! |
|
🤖 Meticulous spotted visual differences in 1 of 130 screens tested: view and approve differences detected. Last updated for commit 247f9b8. This comment will update as new commits are pushed. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Perhaps a tiny nit, even on a 4k screen it looks like it's all a bit smashed together. Maybe we can find a shorter name for the % columns? 
|
Yeah, I agree that a shorter name would be ideal. Would just "X (%)" suffice you think? As in "Cumulative (%)" instead of "Cumulative (% of total)"? |
|
Yes, I think so. As far as I'm aware that's also how other products/projects do this. |
