Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine configuration design docs #1841

Merged
merged 5 commits into from
Apr 27, 2021

Conversation

pellared
Copy link
Member

@pellared pellared commented Apr 26, 2021

Why

Get rid of:

  • unusable exported API
  • unnecessary noise in GoDoc

Make the docs a little less confusing.

Reference: #536 (comment)

What

Changes in configuration deisn docs.

Unexport Apply method

I see no reason to export Apply the method in Option interfaces.
Unexporting the method is also an additional safety net if someone accidentally exports the config struct.

Example in practice: open-telemetry/opentelemetry-go-contrib#750

Change T* to T

I find that using T* for a generic type name may be confusing. Someone may think it is *T when reading quickly (pointer to T). I suggest simply using T as a placeholder.

@pellared
Copy link
Member Author

Can someone add Skip Changelog label, please? 😉

@XSAM XSAM added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 26, 2021
@MrAlias MrAlias added the documentation Provides helpful information label Apr 26, 2021
@pellared pellared force-pushed the update-configuration-docs branch from 38681de to 1bc2d83 Compare April 27, 2021 16:27
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scope of the PR has crept beyond the initial scope of just addressing the content of the configuration style guide. I think the generalized markdown formatting changes are a great addition, but can we move them to another PR?

@pellared
Copy link
Member Author

a great addition, but can we move them to another PR?

Do you have a strong opinion here? 😉 I won't be able to fix it today and I think we would lose more time on the PRs than it is worth.

@MrAlias
Copy link
Contributor

MrAlias commented Apr 27, 2021

a great addition, but can we move them to another PR?

Do you have a strong opinion here? I won't be able to fix it today and I think we would lose more time on the PRs than it is worth.

Without splitting things out this PR needs to have all the approvers re-evaluate their approval as the scope and content have changed. I think it is probably the best approach to revert the changes here and add them to another PR. Once the revert is done here we can merge this.

@MrAlias
Copy link
Contributor

MrAlias commented Apr 27, 2021

We have a bit of an honor system around re-requesting reviews after substantive changes have been made to a PR: https://github.com/open-telemetry/opentelemetry-go/blob/main/CONTRIBUTING.md#how-to-get-prs-merged

If you want to keep the PR as is, please re-request reviews.

@pellared pellared force-pushed the update-configuration-docs branch from 1bc2d83 to 27193c3 Compare April 27, 2021 17:45
@pellared
Copy link
Member Author

the best approach to revert the changes here and add them to another PR. Once the revert is done here we can merge this.

Done 😉 I will create a PR for reformatting all Go markdown code blocks once this is merged.

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #1841 (b6b8b11) into main (24a9162) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1841     +/-   ##
=======================================
- Coverage   78.6%   78.5%   -0.1%     
=======================================
  Files        137     137             
  Lines       7298    7298             
=======================================
- Hits        5739    5736      -3     
- Misses      1315    1316      +1     
- Partials     244     246      +2     
Impacted Files Coverage Δ
sdk/resource/resource.go 64.2% <0.0%> (-3.6%) ⬇️
sdk/trace/batch_span_processor.go 82.4% <0.0%> (-1.6%) ⬇️
exporters/trace/jaeger/jaeger.go 92.8% <0.0%> (+0.5%) ⬆️

@MrAlias MrAlias merged commit 392a44f into open-telemetry:main Apr 27, 2021
@pellared pellared deleted the update-configuration-docs branch April 27, 2021 18:04
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants