-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine configuration design docs #1841
Refine configuration design docs #1841
Conversation
Can someone add |
38681de
to
1bc2d83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scope of the PR has crept beyond the initial scope of just addressing the content of the configuration style guide. I think the generalized markdown formatting changes are a great addition, but can we move them to another PR?
Do you have a strong opinion here? 😉 I won't be able to fix it today and I think we would lose more time on the PRs than it is worth. |
Without splitting things out this PR needs to have all the approvers re-evaluate their approval as the scope and content have changed. I think it is probably the best approach to revert the changes here and add them to another PR. Once the revert is done here we can merge this. |
We have a bit of an honor system around re-requesting reviews after substantive changes have been made to a PR: https://github.com/open-telemetry/opentelemetry-go/blob/main/CONTRIBUTING.md#how-to-get-prs-merged If you want to keep the PR as is, please re-request reviews. |
1bc2d83
to
27193c3
Compare
Done 😉 I will create a PR for reformatting all Go markdown code blocks once this is merged. |
Codecov Report
@@ Coverage Diff @@
## main #1841 +/- ##
=======================================
- Coverage 78.6% 78.5% -0.1%
=======================================
Files 137 137
Lines 7298 7298
=======================================
- Hits 5739 5736 -3
- Misses 1315 1316 +1
- Partials 244 246 +2
|
Why
Get rid of:
Make the docs a little less confusing.
Reference: #536 (comment)
What
Changes in configuration deisn docs.
Unexport Apply method
I see no reason to export
Apply
the method inOption
interfaces.Unexporting the method is also an additional safety net if someone accidentally exports the
config
struct.Example in practice: open-telemetry/opentelemetry-go-contrib#750
Change T* to T
I find that using
T*
for a generic type name may be confusing. Someone may think it is*T
when reading quickly (pointer to T). I suggest simply usingT
as a placeholder.