Fix testCollectorEndpoint typo and add tag assertions in jaeger_test #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IrisTuntun
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MrAlias,
paivagustavo and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1753 +/- ##
=====================================
Coverage 78.6% 78.6%
=====================================
Files 133 133
Lines 7072 7072
=====================================
+ Hits 5560 5564 +4
+ Misses 1267 1265 -2
+ Partials 245 243 -2
|
XSAM
reviewed
Mar 30, 2021
MrAlias
reviewed
Mar 30, 2021
MrAlias
reviewed
Mar 31, 2021
MrAlias
approved these changes
Apr 1, 2021
Aneurysm9
approved these changes
Apr 1, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testCollectorEnpointtotestCollectorEndpoint.gen.Batchthat was exported inTestNewExporterPipelineWithOptions.Fixes #1699
Note: gen.Batch has already been recorded in testCollectorEndpoint thanks to #1693