Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test exporting a batch of spans from Jaeger Exporter is working as expected #1699

Closed
3 tasks
XSAM opened this issue Mar 13, 2021 · 3 comments · Fixed by #1753 · May be fixed by open-o11y/opentelemetry-go#68
Closed
3 tasks

Test exporting a batch of spans from Jaeger Exporter is working as expected #1699

XSAM opened this issue Mar 13, 2021 · 3 comments · Fixed by #1753 · May be fixed by open-o11y/opentelemetry-go#68
Assignees
@IrisTuntun
Labels
area:trace Part of OpenTelemetry tracing good first issue Good for newcomers
Milestone
RC1

Comments

@XSAM
Copy link
Member

XSAM commented Mar 13, 2021

We need to write some tests to prove the Jaeger Exporter can correctly export a batch of spans, which address this comment

Possible steps:

  • Fix the typo of testCollectorEnpoint to testCollectorEndpoint
  • Refactor testCollectorEndpoint to record all the gen.Batch that was exported.
  • Check the correctness of gen.Batch.
@XSAM XSAM added area:trace Part of OpenTelemetry tracing pkg:exporter labels Mar 13, 2021
@MrAlias
Copy link
Contributor

MrAlias commented Mar 20, 2021

Is this required for the 1.0 RC release? Should it be added to the project/milestone?

@XSAM
Copy link
Member Author

XSAM commented Mar 21, 2021

Is this required for the 1.0 RC release?

Since this test wants to prove a feature, populating Jaeger's Span Process must from Resource, that is required for the 1.0 RC release, I thought the test itself would become required for the 1.0 RC release.

Should it be added to the project/milestone?

Sure thing. I forget to add this.

@XSAM XSAM added this to the RC1 milestone Mar 21, 2021
@Aneurysm9 Aneurysm9 added the good first issue Good for newcomers label Mar 24, 2021
@IrisTuntun
Copy link
Contributor

@Aneurysm9 I'd like to take this issue.

@IrisTuntun IrisTuntun mentioned this issue Mar 27, 2021
Open
This was referenced Mar 29, 2021
Closed
Closed
Merged
@IrisTuntun IrisTuntun mentioned this issue Apr 7, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IrisTuntun IrisTuntun

Labels
area:trace Part of OpenTelemetry tracing good first issue Good for newcomers
Projects
None yet
Milestone
RC1
4 participants
@Aneurysm9 @MrAlias @XSAM @IrisTuntun