Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#7003): Imagery layer checkbox should match layer visibility #7004

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

shefalijoshi
Copy link
Contributor

Original issue: #6266 #6992

#7003)

Set layer visibility to false if layer visibility cannot be persisted
@ozyx ozyx changed the title cherry-pick(6266): Imagery layer checkbox should match layer visiblit… cherry-pick(#7003): Imagery layer checkbox should match layer visibility Aug 28, 2023
@ozyx ozyx self-requested a review August 28, 2023 17:41
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozyx ozyx enabled auto-merge (squash) August 28, 2023 17:41
@deploysentinel
Copy link

deploysentinel bot commented Aug 28, 2023

Current Playwright Test Results Summary

✅ 137 Passing - ⚠️ 7 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/28/2023 05:47:51pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 3c4b790

Started: 08/28/2023 05:40:56pm UTC

⚠️ Flakes

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 3 Flakes

Top 1 Common Error Messages

null

3 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery in Display Layout View Large action pauses imagery when in realtime and returns to realtime
Retry 1Initial Attempt
0% (0) 0 / 58 runs
failed over last 7 days
10.34% (6) 6 / 58 runs
flaked over last 7 days
Example Imagery in Display Layout View Large action leaves keeps realtime mode paused
Retry 1Initial Attempt
0% (0) 0 / 58 runs
failed over last 7 days
3.45% (2) 2 / 58 runs
flaked over last 7 days
Example Imagery in Display Layout Resizing the layout changes thumbnail visibility and size
Retry 1Initial Attempt
0% (0) 0 / 58 runs
failed over last 7 days
1.72% (1) 1 / 58 run
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
3.45% (2) 2 / 58 runs
failed over last 7 days
41.38% (24) 24 / 58 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 56 runs
failed over last 7 days
39.29% (22) 22 / 56 runs
flaked over last 7 days

📄   functional/plugins/plot/tagging.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Plot Tagging Tags work with Overlay Plots
Retry 1Initial Attempt
7.02% (4) 4 / 57 runs
failed over last 7 days
31.58% (18) 18 / 57 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 88 runs
failed over last 7 days
51.14% (45) 45 / 88 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/28/2023 05:47:51pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 3c4b790

Started: 08/28/2023 05:41:53pm UTC

View Detailed Build Results


@ozyx ozyx merged commit 1423c23 into release/3.0.1 Aug 28, 2023
@ozyx ozyx deleted the cherry-pick-7003 branch August 28, 2023 17:48
@unlikelyzero unlikelyzero added this to the Target:3.0.1 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants