[Imagery overlay layers] Image layer enabled state shown incorrectly

[charlesh88]

Summary

Turning a layer visible for a given image data product doesn't retain that setting for that object through navigation and browser refresh events.

Expected vs Current Behavior

The layer visibility settings should persist at least in session for a given image view. So, turning a layer visible for a given image data product should retain that setting for that object through navigation and browser refresh events.

Steps to Reproduce

1. View imagery that utilizes overlay layers, such as the overlay grid.

2. Use the layer control to toggle a layer on. Note that the overlay layer is displayed.

3. Nav away from the view, then back. Use the layer control again, and note that the previously enabled layer is checked on, but the corresponding overlay layer is not displayed.

Environment

• Open MCT Version: 2.1.6-SNAPSHOT
• Deployment Type: /testathon
• OS:
• Browser:

Impact Check List

• Data loss or misrepresented data?
• Regression? Did this used to work or has it always been broken?
• Is there a workaround available?
• Does this impact a critical component?
• Is this just a visual bug with no functional impact?
• Does this block the execution of e2e tests?
• Does this have an impact on Performance?

Additional Information

[davetsay]

@charlesh88 , is this still happening? i think this has been fixed

[akhenry]

This is still an issue, I don't think it was ever fixed.

[akhenry]

image layer settings cannot be persisted right now (images are parameters and are immutable).

What is happening is that initial state of the layer is incorrectly reflected in the checkbox. It shows the layer enabled when it is not.

[scottbell]

@charlesh88 @akhenry What's a good imagery product to test this on? I'm not seeing a grid overlay in our default example imagery:

[scottbell]

Using the default imagery layers on an immutable local storage system (by deleting update, create, etc.), it looks like the layers are properly initializing as disabled. I suspect the issue is in another plugin:

Screen.Recording.2023-08-25.at.12.38.07.PM.mov

[shefalijoshi]

@scottbell It looks like the domainObject.configuration is {} for VIPER imagery objects. So it doesn't find the visible value on load. The layer visibililty is not persisted because the openmct.objects.isPersistable method returns false.

[scottbell]

I think the layers not being persisted is ok (per @akhenry's comment), we just need to default the "Grid" layout for VIPER imagery objects to off if it can't find a visible value on load like the other layers. As I don't have access to the VIPER imagery objects, I think @ozyx was going to take a look at this ticket next.

[shefalijoshi]

Testing instructions:
Toggle imagery layers on and off (especially for the VIPER deployment)
Navigate away and back and ensure the imagery layer toggle state (checked/unchecked) matches the visible layers.

[rukmini-bose]

Verified Testathon 9/12/2023. Navigating away and back will default the grid layers to off, and the toggle state matches that as well.

[charlesh88]

Verified fixed Testathon 2023-09-12.

[michaelrogers]

Fix verified during testathon 09/12/2023.