fix(dialog): empty description #6986
Conversation
Current Playwright Test Results Summary✅ 136 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/28/2023 10:03:12pm UTC) |
Codecov Report
@@ Coverage Diff @@
## master #6986 +/- ##
==========================================
- Coverage 48.21% 46.88% -1.33%
==========================================
Files 643 643
Lines 25730 25730
Branches 2512 2512
==========================================
- Hits 12405 12063 -342
- Misses 12844 13186 +342
Partials 481 481
*This pull request uses carry forward flags. Click here to find out more.
... and 54 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -63,6 +63,11 @@ test.describe('Operator Status', () => { | |||
| await expect(page.locator('.c-status-poll-panel')).toBeVisible(); | |||
| }); | |||
|
|
|||
| // Description should be empty https://github.com/nasa/openmct/issues/6978 | |||
| test('no description in role selection', async ({ page }) => { | |||
| await expect(page.locator('.c-message__action-text')).toBeHidden(); | |||
There was a problem hiding this comment.
Couple suggestions here.
Instead of creating a whole new test for this, let's just add an assertion to the beforeEach since that's where we open the user role dialog. Let's also assert that the text is an empty string.
There was a problem hiding this comment.
Done! Due the nature of the v-if conditional, the section isn't rendered, so it won't be visible
There was a problem hiding this comment.
Good stuff. Lmk if you need anything else
Closes #6978
Describe your changes:
Dont show description in role dialog
All Submissions:
Author Checklist
Reviewer Checklist