Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#6916): [Tooltips] Fixes for dictionary objects and self-referential objects #6950

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

khalidadil
Copy link
Contributor

Closes #6810

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

…6916)

* Fix getTelemetryPath to handle cases where parent is the same as the child, handle yamcs aggregate telemetry, and fix how identifiers are passed in

* Cleanup getTelemetryPath

* Switch to filter instead of forEach

* Get path item names

* Remove tooltips on scroll of tree

* Remove handing for scroll

* Allow break-words

* Cleanup
@khalidadil khalidadil changed the title cherry-pick(#6927): [Tooltips] Fixes for dictionary objects and self-referential objects cherry-pick(#3f80b53): [Tooltips] Fixes for dictionary objects and self-referential objects Aug 17, 2023
@khalidadil khalidadil changed the title cherry-pick(#3f80b53): [Tooltips] Fixes for dictionary objects and self-referential objects cherry-pick(#6916): [Tooltips] Fixes for dictionary objects and self-referential objects Aug 17, 2023
@khalidadil khalidadil requested a review from ozyx August 17, 2023 17:10
@deploysentinel
Copy link

deploysentinel bot commented Aug 17, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/17/2023 05:17:51pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: ab6e8aa

Started: 08/17/2023 05:13:05pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 137 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/17/2023 05:17:51pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: ab6e8aa

Started: 08/17/2023 05:12:02pm UTC

⚠️ Flakes

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 182 runs
failed over last 7 days
56.04% (102) 102 / 182 runs
flaked over last 7 days

View Detailed Build Results


@ozyx ozyx merged commit 2002396 into release/3.0.1 Aug 17, 2023
@ozyx ozyx deleted the bugfix/issue-6810-3.0.1 branch August 17, 2023 17:19
@ozyx ozyx added this to the Target:3.0.1 milestone Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants