[Tooltips] Fixes for dictionary objects and self-referential objects #6916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…child, handle yamcs aggregate telemetry, and fix how identifiers are passed in
…nto bugfix/issue-6810
7 tasks
khalidadil
changed the title
Current Playwright Test Results Summary✅ 136 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/17/2023 04:18:11pm UTC)
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 149 runsfailed over last 7 days |
43.62% (65)65 / 149 runsflaked over last 7 days |
|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 148 runsfailed over last 7 days |
41.22% (61)61 / 148 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Example Imagery Object Can use independent time conductor to change time
Retry 2 • Retry 1 • Initial Attempt |
4% (6)6 / 150 runsfailed over last 7 days |
6.67% (10)10 / 150 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0% (0)0 / 180 runsfailed over last 7 days |
55.56% (100)100 / 180 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 14 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 08/17/2023 04:18:11pm UTC)
Run Details
Running Workflow e2e-couchdb on Github Actions
Commit: a364f2f
Started: 08/17/2023 02:33:43pm UTC
⚠️ Flakes
📄 functional/plugins/displayLayout/displayLayout.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 2 • Retry 1 • Initial Attempt |
11.67% (7)7 / 60 runsfailed over last 7 days |
26.67% (16)16 / 60 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6916 +/- ##
==========================================
- Coverage 48.31% 46.88% -1.44%
==========================================
Files 643 643
Lines 25700 25706 +6
Branches 2509 2509
==========================================
- Hits 12417 12052 -365
- Misses 12804 13174 +370
- Partials 479 480 +1
*This pull request uses carry forward flags. Click here to find out more.
... and 54 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ozyx
suggested changes
Aug 14, 2023
khalidadil
commented
Aug 16, 2023
khalidadil
commented
Aug 16, 2023
ozyx
approved these changes
Aug 16, 2023
| } | ||
| telemetryPath.unshift(pathObject.name); | ||
| }); | ||
| telemetryPath = telemetryPathObjects |
khalidadil
added a commit
that referenced
this pull request
Aug 17, 2023
…6916) * Fix getTelemetryPath to handle cases where parent is the same as the child, handle yamcs aggregate telemetry, and fix how identifiers are passed in * Cleanup getTelemetryPath * Switch to filter instead of forEach * Get path item names * Remove tooltips on scroll of tree * Remove handing for scroll * Allow break-words * Cleanup
ozyx
pushed a commit
that referenced
this pull request
Aug 17, 2023
…referential objects (#6950) [Tooltips] Fixes for dictionary objects and self-referential objects (#6916) * Fix getTelemetryPath to handle cases where parent is the same as the child, handle yamcs aggregate telemetry, and fix how identifiers are passed in * Cleanup getTelemetryPath * Switch to filter instead of forEach * Get path item names * Remove tooltips on scroll of tree * Remove handing for scroll * Allow break-words * Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6810
All Submissions:
Author Checklist
Reviewer Checklist