Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#6868): fix: toggling markers, alarm markers, marker style + update Vue.extend() usage to Vue 3 #6873

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Aug 1, 2023

  • fix: update to defineComponent from Vue.extend()
  • fix: unwrap Proxy arg before WeakMap.get()
  • refactor: defineComponent not needed here

Issue #6823
Issue #6867

…e + update `Vue.extend()` usage to Vue 3

* fix: update to `defineComponent` from `Vue.extend()`
* fix: unwrap Proxy arg before WeakMap.get()
* refactor: `defineComponent` not needed here
@ozyx ozyx requested a review from akhenry August 1, 2023 21:12
@ozyx ozyx enabled auto-merge (squash) August 1, 2023 21:12
@akhenry akhenry disabled auto-merge August 1, 2023 21:16
@akhenry akhenry merged commit 44415b3 into release/3.0.0 Aug 1, 2023
@akhenry akhenry deleted the cherry-pick-6868 branch August 1, 2023 21:16
@deploysentinel
Copy link

deploysentinel bot commented Aug 1, 2023

Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/01/2023 09:18:03pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: df1f76f

Started: 08/01/2023 09:15:30pm UTC

⚠️ Flakes

📄   functional/tree.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Main Tree Creating a child object on one tab and expanding its parent on the other shows the correct composition @couchdb @2p
Retry 1Initial Attempt
0% (0) 0 / 51 runs
failed over last 7 days
13.73% (7) 7 / 51 runs
flaked over last 7 days

View Detailed Build Results


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants