-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: toggling markers, alarm markers, marker style + update Vue.extend()
usage to Vue 3
#6868
Conversation
Current Playwright Test Results Summary✅ 130 Passing - ❌ 1 Failing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/01/2023 09:14:00pm UTC) ❌ Failures📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 FailureTest Case Results
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 1 • Initial Attempt |
10% (10)10 / 100 runsfailed over last 7 days |
38% (38)38 / 100 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 14 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 08/01/2023 09:14:00pm UTC)
Run Details
Running Workflow e2e-couchdb on Github Actions
Commit: fdfba13
Started: 08/01/2023 06:12:18pm UTC
⚠️ Flakes
📄 functional/tree.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Main Tree Creating a child object on one tab and expanding its parent on the other shows the correct composition @couchdb @2p
Retry 1 • Initial Attempt |
0% (0)0 / 49 runsfailed over last 7 days |
12.24% (6)6 / 49 runsflaked over last 7 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing test, otherwise LGTM. Investigating...
…e + update `Vue.extend()` usage to Vue 3 * fix: update to `defineComponent` from `Vue.extend()` * fix: unwrap Proxy arg before WeakMap.get() * refactor: `defineComponent` not needed here
…e + update `Vue.extend()` usage to Vue 3 (#6873) * fix: update to `defineComponent` from `Vue.extend()` * fix: unwrap Proxy arg before WeakMap.get() * refactor: `defineComponent` not needed here
Closes #6823
Closes #6867
Describe your changes:
Our seriesElements and seriesLimits are stored in a
WeakMap
which is keyed on an object which has become reactive in Vue 3, and thus wrapped in a Proxy. As such, lookups with the Proxy-wrapped version of this object returnundefined
. The solution is to unwrap the Proxy usingtoRaw()
before accessing the map.I have also removed our usage of
Vue.extend()
and replaced it with our samemount
pattern for creating limitLines and limitLabels.All Submissions:
Author Checklist
Reviewer Checklist