Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Plan View duplicate scrollbars #6865

Merged
merged 7 commits into from
Aug 7, 2023
Merged

Conversation

charlesh88
Copy link
Contributor

@charlesh88 charlesh88 commented Aug 1, 2023

Closes #6864

Closes

Describe your changes:

  • CSS fixes to remove problematic duplicate overflow handling.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes? N/A
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@charlesh88 charlesh88 requested a review from shefalijoshi August 1, 2023 00:03
@deploysentinel
Copy link

deploysentinel bot commented Aug 1, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/07/2023 10:48:19pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 732ff35

Started: 08/07/2023 10:46:24pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 134 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/07/2023 10:48:19pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 732ff35

Started: 08/07/2023 10:36:21pm UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
3.30% (3) 3 / 91 runs
failed over last 7 days
15.38% (14) 14 / 91 runs
flaked over last 7 days

📄   functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 1Initial Attempt
12.28% (14) 14 / 114 runs
failed over last 7 days
38.60% (44) 44 / 114 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0% (0) 0 / 92 runs
failed over last 7 days
19.57% (18) 18 / 92 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 92 runs
failed over last 7 days
27.17% (25) 25 / 92 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozyx
Copy link
Contributor

ozyx commented Aug 1, 2023

autoscale test failing. need to look into why and fix it

charlesh88 and others added 2 commits August 3, 2023 13:19
- CSS fixes to remove problematic duplicate overflow handling.
@ozyx ozyx force-pushed the fix/plan-view-scrollbars-6864 branch from fbee261 to 6de5818 Compare August 3, 2023 20:19
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #6865 (732ff35) into master (9942bbb) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6865      +/-   ##
==========================================
+ Coverage   48.33%   48.34%   +0.01%     
==========================================
  Files         643      643              
  Lines       25626    25626              
  Branches     2496     2496              
==========================================
+ Hits        12387    12390       +3     
+ Misses      12763    12760       -3     
  Partials      476      476              
Flag Coverage Δ *Carryforward flag
e2e-full 42.01% <ø> (-0.08%) ⬇️ Carriedforward from 97d170e
e2e-stable 57.12% <ø> (+0.65%) ⬆️
unit 38.75% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9942bbb...732ff35. Read the comment docs.

@ozyx ozyx force-pushed the fix/plan-view-scrollbars-6864 branch from 69bc14f to 6de5818 Compare August 3, 2023 20:36
@unlikelyzero unlikelyzero added this to the Target:3.1.0 milestone Aug 4, 2023
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 7, 2023
@ozyx ozyx enabled auto-merge (squash) August 7, 2023 22:43
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 7, 2023
@ozyx ozyx merged commit accfbc9 into master Aug 7, 2023
@ozyx ozyx deleted the fix/plan-view-scrollbars-6864 branch August 7, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plan view showing duplicate scrollbars
4 participants