Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plan view showing duplicate scrollbars #6864

Closed
1 of 7 tasks
charlesh88 opened this issue Jul 31, 2023 · 3 comments · Fixed by #6865
Closed
1 of 7 tasks

Plan view showing duplicate scrollbars #6864

charlesh88 opened this issue Jul 31, 2023 · 3 comments · Fixed by #6865
Labels
severity:medium type:bug
Milestone
Target:3.0.0

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Jul 31, 2023 •
edited
Loading

Summary

For Plan views that aren't using clipped Activity names, in some cases the view will display multiple scroll bars and get into a repetitive "joggling" animation. This results from a second scrollbar being activated, which causes the area width to change and Activities to reflow, which then removes the second scrollbar and causes another reflow, which then starts the cycle anew.

Main view

Plan scroll boogie

In a Display Layout

Plan scroll boogie in Display Layout

Expected vs Current Behavior

The second scrollbar should not be displayed. Removing overflow-y: auto on c-plan c-timeline-holder fixes the problem, but make sure this doesn't mess things up in other views:
image

Steps to Reproduce

  1. Use a Plan view that doesn't use clipped Activity names.
  2. Size the view area of a Plan view such that a number of activities are hidden beneath the scroll.
  3. Slowly tweak the width of the view area until a second scrollbar appears and the view starts to joggle. While increasing the area width, look for the moment when an Activity is allowed to flow horizontally after another but just fits. Then, shrink the area width slowly until joggling occurs.

Plan scroll boogie pane width drag

Environment

  • Open MCT Version: 3.0.0
  • Deployment Type:
  • OS: any
  • Browser: all

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@charlesh88 charlesh88 self-assigned this Jul 31, 2023
charlesh88 added a commit that referenced this issue Jul 31, 2023
@charlesh88
Closes #6864
8b6e223 
- CSS fixes to remove problematic duplicate overflow handling.
@charlesh88
Copy link
Contributor Author

charlesh88 commented Jul 31, 2023 •
edited
Loading

Testing Notes

Follow replication steps above and ensure you can't force the problem.

@charlesh88 charlesh88 mentioned this issue Aug 1, 2023
Merged
15 tasks
ozyx pushed a commit that referenced this issue Aug 3, 2023
@charlesh88 @ozyx
Closes #6864
49db098 
- CSS fixes to remove problematic duplicate overflow handling.
@ozyx ozyx closed this as completed in #6865 Aug 7, 2023
ozyx added a commit that referenced this issue Aug 7, 2023
@charlesh88 @ozyx
Fix Plan View duplicate scrollbars (#6865)
accfbc9 
* Closes #6864
- CSS fixes to remove problematic duplicate overflow handling.

* fix(e2e): stabilize autoscale test

* fix(e2e): mark overlay plot tagging test as slow

* fix(e2e): stabilize ITC e2e test

* fix(e2e): don't use hard wait

* fix: remove .only 😳

---------

Co-authored-by: Jesse Mazzella <[email protected]>
Co-authored-by: Jesse Mazzella <[email protected]>
@charlesh88
Copy link
Contributor Author

Verified fixed Testathon 2023-08-22.

@rukmini-bose
Copy link
Contributor

verified testathon 8/22/23

@unlikelyzero unlikelyzero added this to the Target:3.0.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity:medium type:bug
Projects
None yet
Milestone
Target:3.0.0
Development

Successfully merging a pull request may close this issue.

Fix Plan View duplicate scrollbars nasa/openmct
4 participants
@charlesh88 @shefalijoshi @unlikelyzero @rukmini-bose