Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Time] use clock current value instead of end bounds for current time #6405

Merged
merged 5 commits into from
Mar 16, 2023

Conversation

davetsay
Copy link
Contributor

@davetsay davetsay commented Mar 8, 2023

Closes #4350

Describe your changes:

Title says it all

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #6405 (2147de7) into master (ff3a20e) will increase coverage by 0.19%.
The diff coverage is 100.00%.

❗ Current head 2147de7 differs from pull request most recent head c2fd419. Consider uploading reports for the commit c2fd419 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6405      +/-   ##
==========================================
+ Coverage   54.70%   54.90%   +0.19%     
==========================================
  Files         626      620       -6     
  Lines       26593    26529      -64     
  Branches     2402     2401       -1     
==========================================
+ Hits        14547    14565      +18     
+ Misses      11383    11303      -80     
+ Partials      663      661       -2     
Flag Coverage Δ *Carryforward flag
e2e-ci 39.40% <ø> (+0.02%) ⬆️ Carriedforward from 0b3e0e7
e2e-full 51.15% <ø> (-0.01%) ⬇️ Carriedforward from 0b3e0e7
e2e-stable 54.56% <ø> (+2.37%) ⬆️
unit 49.38% <100.00%> (+0.15%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../plugins/timeConductor/ConductorInputsRealtime.vue 54.94% <100.00%> (+4.94%) ⬆️

... and 36 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff3a20e...c2fd419. Read the comment docs.

@ozyx ozyx self-requested a review March 15, 2023 18:26
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- tested locally and with independent time conductor. seems to work well!

@ozyx ozyx enabled auto-merge (squash) March 16, 2023 17:46
@ozyx ozyx merged commit 1dc137f into master Mar 16, 2023
@ozyx ozyx deleted the fix/4350-current-time branch March 16, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time Conductor "Current" value is wrong in real-time mode
2 participants